conduit icon indicating copy to clipboard operation
conduit copied to clipboard

[UI] Rollback pipeline delete if error

Open jmar910 opened this issue 3 years ago • 2 comments

Description

We don't explicitly catch on pipeline destroy when the API errors, so the pipeline itself was going into a deleted state and was causing issues with ember refetching the model. Now we catch on pipeline destroy and do a rollback, which appropriately resets the state.

Fixes https://github.com/ConduitIO/conduit/issues/592

Quick checks:

  • [x] I have followed the Code Guidelines.
  • [x] There is no other pull request for the same update/change.
  • [x] I have written unit tests.
  • [x] I have made sure that the PR is of reasonable size and can be easily reviewed.

jmar910 avatar Sep 21 '22 19:09 jmar910

UI test coverage: 76.2%

:rotating_light: Decreased by -0.23% (was 76.43%)

github-actions[bot] avatar Sep 21 '22 19:09 github-actions[bot]

UI test coverage: 77.08%

:tada: Increased by +0.65% (was 76.43%)

github-actions[bot] avatar Sep 22 '22 21:09 github-actions[bot]

UI test coverage: 77.08%

:tada: Increased by +0.65% (was 76.43%)

github-actions[bot] avatar Sep 23 '22 17:09 github-actions[bot]