libSplash icon indicating copy to clipboard operation
libSplash copied to clipboard

Revert Attributes: Offset, Size

Open ax3l opened this issue 10 years ago • 4 comments

~~We just changed the file format in a full version to introduce h5py compatible bool values in #153 #198.~~

~~With the upcoming release of 1.3 we could use that file format change and also~~

to be correctly in z,y,x order too (we also flip the coordinates of the data sets correctly). That would reduce the confusion for users while reading our data with other tools, e.g., with h5py.

Might also need:

  • [ ] an update of our tools for xdmf

Spotted by @psychocoderHPC - @f-schmitt-zih do you agree?

ax3l avatar Mar 31 '15 11:03 ax3l

Of course, sounds like a good change! I wouldn't call it a bug, though.

f-schmitt avatar May 04 '15 00:05 f-schmitt

True, it's more of a refactoring :)

ax3l avatar May 04 '15 06:05 ax3l

an other day where I tried to refactor this and it's just super confusing and we barely have 2D data sets in the examples/tests...

it's a bit tricky since the Dimension object is always a 3D object which is horrible brainf*k for 2D data sets

ax3l avatar Nov 09 '15 13:11 ax3l

moving this to 2.0, it just hurts too look at it.

Working PR's for 1, 2 and 3D data sets are very welcome.

ax3l avatar Nov 09 '15 14:11 ax3l