libSplash

libSplash copied to clipboard

From the docs: ``` Name: H5Tget_member_name ... The HDF5 Library allocates a buffer to receive the name of the field. The caller must subsequently free the buffer with H5free_memory. ```...

ax3l

OpenMPI: Use ROMIO for IO

1

A note on using libSplash with OpenMPI: OpenMPI's default for its IO backend is OMPIO, [starting with 2.x](https://www.open-mpi.org/faq/?category=ompio). Unfortunately, that backend contains severe bugs leading to data corruption and sporadic...

ax3l

Compiling with GCC 8.2.0 throws several warnings of the form: ``` warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated] void* buf) throw (DCException); ```

ax3l

We currently (1.7.0) link in `CMakeLists.txt` to `ZLIB::ZLIB`, although we do not include zlib directly in Splash. This dependency should nowadays (recent CMake versions such as our 3.10+) be properly...

ax3l

hdf5 dimension labels and bin values

5

HDF5 seems to support dimension scales and labels [[1]](http://docs.h5py.org/en/latest/high/dims.html). Is this already included in _libSplash_? If no, do you think this might be a good feature to add? I think,...

PrometheusPi

Noticed in #259 and #248: There is one failed test for the "Fix compile errors" commit in #259 with a `assertion failed - Expression: sum == old_sum` in only one...

Flamefire

Is there currently any way to check the type of an attribute? I currently see only the interface `readAttribute(int32_t id, const char *dataName, const char *attrName, void* data)` which completely...

Flamefire

Remove Dimensions::getDims

12

This function (https://github.com/ComputationalRadiationPhysics/libSplash/blob/master/src/include/splash/Dimensions.hpp#L252-L263) is wrong, as it does neither honor zero sizes (all dims=0) nor does it work for offsets. As it can't be fixed properly in that design, it...

Flamefire

Pass CollectionType when reading

1

HDF5 does datatype conversion when required (https://www.hdfgroup.org/HDF5/doc/UG/HDF5_Users_Guide-Responsive%20HTML5/index.html#t=HDF5_Users_Guide%2FDatatypes%2FHDF5_Datatypes.htm%23TOC_6_10_Data_Transferbc-26&rhtocid=6.5_2) So the interfaces should accept a `CollectionType` when reading making the read/write signature almost the same. Example: ``` virtual void readAttribute(int32_t id, const...

Flamefire

HDF5 can convert data in an endianess aware way. But currently the datatype stored in the file is always used, which will lead to wrong results in cases where the...

Flamefire