content icon indicating copy to clipboard operation
content copied to clipboard

Remove mount option custom tests and add templated tests

Open ggbecker opened this issue 3 years ago • 5 comments

Description:

  • Remove custom tests for rules that use mount_option template
  • Add templated tests for mount_option
  • Add config to skip templated tests for /boot partition.

Rationale:

  • No more custom tests for rules that don't specially need custom tests.

ggbecker avatar May 17 '22 12:05 ggbecker

Start a new ephemeral environment with changes proposed in this pull request:

Open in Gitpod

github-actions[bot] avatar May 17 '22 12:05 github-actions[bot]

There are some more work required here, some tests have the same name but have different expected results. Based on parameters input. We should probably move the results expectation into the metadata of test scenarios so we can have different expected results based on the input.

ggbecker avatar May 17 '22 14:05 ggbecker

@ggbecker: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ocp4-stig 619e072de4b17df8fcd68ec2b166da73ba042f7b link true /test e2e-aws-ocp4-stig

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 21 '22 18:06 openshift-ci[bot]

@ggbecker Do you have plans to continue work on this PR or would you prefer to close it?

jan-cerny avatar Aug 26 '22 07:08 jan-cerny

@ggbecker: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Sep 07 '22 13:09 openshift-merge-robot

Based on contributing guidelines https://github.com/ComplianceAsCode/content/blob/master/CONTRIBUTING.md we are closing this PR because of 30 days of inactivity. Feel free to reopen the PR if you wish to continue working on it.

jan-cerny avatar Sep 26 '22 13:09 jan-cerny