content icon indicating copy to clipboard operation
content copied to clipboard

OCP4: Add option to deploy profile without upstream prefix

Open Vincent056 opened this issue 2 years ago • 5 comments

This pr add the ability to deploy profile without upstream prefix. ex. when you run the script to deploy ocp4 profile bundle, all the profiles will have upstream in the name prefix, upstream-ocp4-cis, and with -np option, we do not add upstream prefix to it automatically.

Vincent056 avatar Dec 01 '23 06:12 Vincent056

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Dec 01 '23 06:12 github-actions[bot]

Code Climate has analyzed commit 0458e28f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5%.

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Dec 01 '23 06:12 qlty-cloud-legacy[bot]

/packit retest-failed

Mab879 avatar Dec 05 '23 22:12 Mab879

verification passed

$ ./utils/build_ds_container.py -c -p  --no-upstream-prefix
2024-01-08 16:16:22,746:INFO: Building content for ocp4, rhcos4
2024-01-08 16:17:24,253:INFO: Build status: Running
2024-01-08 16:17:28,811:INFO: Build status: Running
...
before build content:
$ oc get pb
NAME     CONTENTIMAGE                                 CONTENTFILE         STATUS
ocp4     ghcr.io/complianceascode/k8scontent:latest   ssg-ocp4-ds.xml     VALID
rhcos4   ghcr.io/complianceascode/k8scontent:latest   ssg-rhcos4-ds.xml   VALID

After build upstream content
$ oc get pb -w
NAME     CONTENTIMAGE                                 CONTENTFILE         STATUS
ocp4     ghcr.io/complianceascode/k8scontent:latest   ssg-ocp4-ds.xml     VALID
rhcos4   ghcr.io/complianceascode/k8scontent:latest   ssg-rhcos4-ds.xml   VALID
ocp4     openscap-ocp4-ds:latest                      ssg-ocp4-ds.xml     VALID
ocp4     openscap-ocp4-ds:latest                      ssg-ocp4-ds.xml     PENDING
rhcos4   openscap-ocp4-ds:latest                      ssg-rhcos4-ds.xml   VALID
rhcos4   openscap-ocp4-ds:latest                      ssg-rhcos4-ds.xml   PENDING
ocp4     openscap-ocp4-ds:latest                      ssg-ocp4-ds.xml     VALID
rhcos4   openscap-ocp4-ds:latest                      ssg-rhcos4-ds.xml   VALID

xiaojiey avatar Jan 08 '24 08:01 xiaojiey

/lgtm

xiaojiey avatar Feb 26 '24 06:02 xiaojiey