compliance-operator icon indicating copy to clipboard operation
compliance-operator copied to clipboard

Add enhancement `last-scanned-timestamps`

Open SimonBaeumer opened this issue 1 year ago • 7 comments

This PR adds an enhancement to add a field LastScannedTimestamp to the CheckResult CR.

This enhancement is planned to be implemented by myself. This first iteration is to get consensus on the feature request and discuss possible implementations if necessary.

SimonBaeumer avatar Apr 10 '24 09:04 SimonBaeumer

Hi @SimonBaeumer. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 10 '24 09:04 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SimonBaeumer Once this PR has been reviewed and has the lgtm label, please assign mrogers950 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 10 '24 09:04 openshift-ci[bot]

/ok-to-test

rhmdnd avatar Apr 12 '24 20:04 rhmdnd

/hold for test

xiaojiey avatar Apr 15 '24 05:04 xiaojiey

See #512

SimonBaeumer avatar May 03 '24 08:05 SimonBaeumer

@SimonBaeumer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial fec136efd4e56b24c5a84b025997788202bc8e7a link true /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 19 '24 20:07 openshift-ci[bot]

we have implmentation in https://github.com/ComplianceAsCode/compliance-operator/pull/591

Vincent056 avatar Aug 15 '24 15:08 Vincent056