CommunityToolkit
Camera Video Recording
Description of Change
Linked Issues
- Fixes #2706
PR Checklist
- [ ] Has a linked Issue, and the Issue has been
approved(bug) orChampioned(feature/proposal) - [ ] Has tests (if omitted, state reason in description)
- [ ] Has samples (if omitted, state reason in description)
- [ ] Rebased on top of
mainat time of PR - [ ] Changes adhere to coding standard
- [ ] Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls
Additional information
@VladislavAntonyuk I believe you're using the old Camera2 APi, you should use the CameraX API instead, it will be simpler and it's newer
here for reference https://developer.android.com/media/camera/camerax/video-capture
I see we reference a NuGet for camera 2, that is why I used this implementation. According to Google camera 2 is not obsolete, but allows you to have a full control of the camera. CameraX just a convenient way to work with camera api. I will update to CameraX.
This is looking very well done! I am shocked at how nice some of the code looks. I have for over a year now wanted a solution to async - await for android in dotnet. From looking at this code I can see an easy example I can reference in the future for how to do that! Ty for that alone!
I am going to test on my Mac mini and my iPad later this morning but just looking at the code it looks good to go after you look at my comments. I think all that is left for now is finishing testing and starting the documentation. This is a great addition to the toolkit.
Start video recording on iOS and iOS simulator is crashing on button click with message about not finding camera. https://github.com/CommunityToolkit/Maui/blob/0f0c926e8c27548f9f65ca2c7b4c24fb29aa952d/src/CommunityToolkit.Maui.Camera/CameraManager.macios.cs#L163
Managed to get a stacktrace for MacOS. For some reason the debugger was not working for either iOS simulator or device.
MacOS:
ObjCRuntime.ObjCException: Objective-C exception thrown. Name: NSInvalidArgumentException Reason: *** -[AVCaptureDevice _setActiveFormat:resetVideoZoomFactorAndMinMaxFrameDurations:sessionPreset:] Unsupported format ((null)) - use -formats to discover valid formats
Native stack trace:
0 CoreFoundation 0x0000000196f6eca0 __exceptionPreprocess + 176
1 libobjc.A.dylib 0x0000000196a32b90 objc_exception_throw + 88
2 AVFCapture 0x00000001b76ca69c -[AVCaptureFigVideoDevice _setActiveFormat:resetVideoZoomFactorAndMinMaxFrameDurations:sessionPreset:] + 4584
3 AVFCapture 0x00000001b7732894 -[AVCaptureSession _updateDeviceActiveFormatsAndActiveConnections] + 2452
4 AVFCapture 0x00000001b77314f4 -[AVCaptureSession _buildAndRunGraph:] + 340
5 AVFCapture 0x00000001b7728528 -[AVCaptureSession _commitConfiguration] + 408
6 AVFCapture 0x00000001b772917c -[AVCaptureSession addInput:] + 764
7 CommunityToolkit.Maui.Sample 0x00000001026d8a58 xamarin_dyn_objc_msgSend + 160
8 CommunityToolkit.Maui.Sample 0x00000001029777a4 do_icall + 200
9 CommunityToolkit.Maui.Sample 0x0000000102975d10 do_icall_wrapper + 356
10 CommunityToolkit.Maui.Sample 0x000000010296a624 mono_interp_exec_method + 2456
11 CommunityToolkit.Maui.Sample 0x0000000102968258 interp_runtime_invoke + 244
12 CommunityToolkit.Maui.Sample 0x00000001028b0324 mono_jit_runtime_invoke + 1268
13 CommunityToolkit.Maui.Sample 0x00000001028521f8 mono_runtime_try_invoke + 156
14 CommunityToolkit.Maui.Sample 0x00000001028541d0 mono_runtime_invoke + 516
15 CommunityToolkit.Maui.Sample 0x00000001029b18bc _ZL30native_to_managed_trampoline_9P11objc_objectP13objc_selectorPP11_MonoMethodj + 276
16 CommunityToolkit.Maui.Sample 0x0000000102a04314 -[__MonoMac_NSAsyncSynchronizationContextDispatcher xamarinApplySelector] + 44
17 Foundation 0x00000001984e8f74 __NSThreadPerformPerform + 264
18 CoreFoundation 0x0000000196efdcd4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 28
19 CoreFoundation 0x0000000196efdc68 __CFRunLoopDoSource0 + 172
20 CoreFoundation 0x0000000196efd9d4 __CFRunLoopDoSources0 + 232
21 CoreFoundation 0x0000000196efc628 __CFRunLoopRun + 840
22 CoreFoundation 0x0000000196efbc58 CFRunLoopRunSpecific + 572
23 HIToolbox 0x00000001a299027c RunCurrentEventLoopInMode + 324
24 HIToolbox 0x00000001a29934e8 ReceiveNextEventCommon + 676
25 HIToolbox 0x00000001a2b1e484 _BlockUntilNextEventMatchingListInModeWithFilter + 76
26 AppKit 0x000000019ae23ab4 _DPSNextEvent + 684
27 AppKit 0x000000019b7c25b0 -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 688
28 AppKit 0x000000019ae16c64 -[NSApplication run] + 480
29 AppKit 0x000000019aded35c NSApplicationMain + 880
30 AppKit 0x000000019b039cf4 +[NSWindow _savedFrameFromString:] + 0
31 UIKitMacHelper 0x00000001b2420164 UINSApplicationMain + 976
32 UIKitCore 0x00000001caa93c9c UIApplicationMain + 148
33 CommunityToolkit.Maui.Sample 0x00000001026ac5a4 xamarin_UIApplicationMain + 60
34 CommunityToolkit.Maui.Sample 0x0000000102977818 do_icall + 316
35 CommunityToolkit.Maui.Sample 0x0000000102975d10 do_icall_wrapper + 356
36 CommunityToolkit.Maui.Sample 0x000000010296a624 mono_interp_exec_method + 2456
37 CommunityToolkit.Maui.Sample 0x0000000102968258 interp_runtime_invoke + 244
38 CommunityToolkit.Maui.Sample 0x00000001028b0324 mono_jit_runtime_invoke + 1268
39 CommunityToolkit.Maui.Sample 0x00000001028508e0 mono_runtime_invoke_checked + 148
40 CommunityToolkit.Maui.Sample 0x0000000102856828 mono_runtime_exec_main_checked + 116
41 CommunityToolkit.Maui.Sample 0x0000000102901bb4 mono_jit_exec + 364
42 CommunityToolkit.Maui.Sample 0x00000001026d75f8 xamarin_main + 832
43 CommunityToolkit.Maui.Sample 0x0000000102a52234 main + 64
44 dyld 0x0000000196a72b98 start + 6076
at AVFoundation.AVCaptureSession.AddInput(AVCaptureInput input) in /Users/builder/azdo/_work/1/s/macios/src/build/dotnet/maccatalyst/generated-sources/AVFoundation/AVCaptureSession.g.cs:line 340
at CommunityToolkit.Maui.Core.CameraManager.<PlatformStartCameraPreview>d__46.MoveNext() in /Users/jamescrutchley/Documents/MauiOld/MauiOld/src/CommunityToolkit.Maui.Camera/CameraManager.macios.cs:line 165
at CommunityToolkit.Maui.Core.CameraManager.<PlatformConnectCamera>d__47.MoveNext() in /Users/jamescrutchley/Documents/MauiOld/MauiOld/src/CommunityToolkit.Maui.Camera/CameraManager.macios.cs:line 139
at CommunityToolkit.Maui.Core.Handlers.CameraViewHandler.ConnectHandler(UIView platformView) in /Users/jamescrutchley/Documents/MauiOld/MauiOld/src/CommunityToolkit.Maui.Camera/Handlers/CameraViewHandler.shared.cs:line 92
at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
at Foundation.NSAsyncSynchronizationContextDispatcher.Apply() in /Users/builder/azdo/_work/1/s/macios/src/Foundation/NSAction.cs:line 179
Native stack trace:
0 CoreFoundation 0x0000000196f6eca0 __exceptionPreprocess + 176
1 libobjc.A.dylib 0x0000000196a32b90 objc_exception_throw + 88
2 AVFCapture 0x00000001b76ca69c -[AVCaptureFigVideoDevice _setActiveFormat:resetVideoZoomFactorAndMinMaxFrameDurations:sessionPreset:] + 4584
3 AVFCapture 0x00000001b7732894 -[AVCaptureSession _updateDeviceActiveFormatsAndActiveConnections] + 2452
4 AVFCapture 0x00000001b77314f4 -[AVCaptureSession _buildAndRunGraph:] + 340
5 AVFCapture 0x00000001b7728528 -[AVCaptureSession _commitConfiguration] + 408
6 AVFCapture 0x00000001b772917c -[AVCaptureSession addInput:] + 764
7 CommunityToolkit.Maui.Sample 0x00000001026d8a58 xamarin_dyn_objc_msgSend + 160
8 CommunityToolkit.Maui.Sample 0x00000001029777a4 do_icall + 200
9 CommunityToolkit.Maui.Sample 0x0000000102975d10 do_icall_wrapper + 356
10 CommunityToolkit.Maui.Sample 0x000000010296a624 mono_interp_exec_method + 2456
11 CommunityToolkit.Maui.Sample 0x0000000102968258 interp_runtime_invoke + 244
12 CommunityToolkit.Maui.Sample 0x00000001028b0324 mono_jit_runtime_invoke + 1268
13 CommunityToolkit.Maui.Sample 0x00000001028521f8 mono_runtime_try_invoke + 156
14 CommunityToolkit.Maui.Sample 0x00000001028541d0 mono_runtime_invoke + 516
15 CommunityToolkit.Maui.Sample 0x00000001029b18bc _ZL30native_to_managed_trampoline_9P11objc_objectP13objc_selectorPP11_MonoMethodj + 276
16 CommunityToolkit.Maui.Sample 0x0000000102a04314 -[__MonoMac_NSAsyncSynchronizationContextDispatcher xamarinApplySelector] + 44
17 Foundation 0x00000001984e8f74 __NSThreadPerformPerform + 264
18 CoreFoundation 0x0000000196efdcd4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 28
19 CoreFoundation 0x0000000196efdc68 __CFRunLoopDoSource0 + 172
20 CoreFoundation 0x0000000196efd9d4 __CFRunLoopDoSources0 + 232
21 CoreFoundation 0x0000000196efc628 __CFRunLoopRun + 840
22 CoreFoundation 0x0000000196efbc58 CFRunLoopRunSpecific + 572
23 HIToolbox 0x00000001a299027c RunCurrentEventLoopInMode + 324
24 HIToolbox 0x00000001a29934e8 ReceiveNextEventCommon + 676
25 HIToolbox 0x00000001a2b1e484 _BlockUntilNextEventMatchingListInModeWithFilter + 76
26 AppKit 0x000000019ae23ab4 _DPSNextEvent + 684
27 AppKit 0x000000019b7c25b0 -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 688
28 AppKit 0x000000019ae16c64 -[NSApplication run] + 480
29 AppKit 0x000000019aded35c NSApplicationMain + 880
30 AppKit 0x000000019b039cf4 +[NSWindow _savedFrameFromString:] + 0
31 UIKitMacHelper 0x00000001b2420164 UINSApplicationMain + 976
32 UIKitCore 0x00000001caa93c9c UIApplicationMain + 148
33 CommunityToolkit.Maui.Sample 0x00000001026ac5a4 xamarin_UIApplicationMain + 60
34 CommunityToolkit.Maui.Sample 0x0000000102977818 do_icall + 316
35 CommunityToolkit.Maui.Sample 0x0000000102975d10 do_icall_wrapper + 356
36 CommunityToolkit.Maui.Sample 0x000000010296a624 mono_interp_exec_method + 2456
37 CommunityToolkit.Maui.Sample 0x0000000102968258 interp_runtime_invoke + 244
38 CommunityToolkit.Maui.Sample 0x00000001028b0324 mono_jit_runtime_invoke + 1268
39 CommunityToolkit.Maui.Sample 0x00000001028508e0 mono_runtime_invoke_checked + 148
40 CommunityToolkit.Maui.Sample 0x0000000102856828 mono_runtime_exec_main_checked + 116
41 CommunityToolkit.Maui.Sample 0x0000000102901bb4 mono_jit_exec + 364
42 CommunityToolkit.Maui.Sample 0x00000001026d75f8 xamarin_main + 832
43 CommunityToolkit.Maui.Sample 0x0000000102a52234 main + 64
44 dyld 0x0000000196a72b98 start + 6076
Hopefully that might help figure out what is going on. I don't have a camera attached to my mac mini. Which is probably an issue but should the sample app crash when you open the camera page? It just CTD when I navigate to camera page.
The camera is not available on iOS simulators; you can only test it on real devices
Hey @TheCodeTraveler, thank you for the code review. Why did you change StartVideoRecording method to return the stream? The idea is to pass any stream and record directly to the stream (see Windows implementation). Also we cannot return stream from the StartVideoRecording and we can create fill the stream at the end of the video recording (android).