MVVM-Samples icon indicating copy to clipboard operation
MVVM-Samples copied to clipboard

Adding Uno support (updated)

Open nickrandolph opened this issue 4 years ago • 4 comments

nickrandolph avatar Jan 29 '21 23:01 nickrandolph

Hey @nickrandolph, sorry for the delay. I didn't see the GitHub notification, not sure if it was because it was a new PR vs. updating the old one.

It seems you hadn't git mv everything. The Xamarin Forms PR has in #33. Could you rebase off that one, then we can also update to compare against it?

Also, I noticed you pinned the SDK Extras to an older version, is there a specific reason you weren't using latest?

And with the Icon Glyphs removed nothing shows for even the UWP sample, right? Does the Uno NavigationViewItem not support the Icons?

Also adding @kazo0 if he has any suggestions as a member of the Uno team and to help us coordinate these two PRs better. Thanks!

michael-hawker avatar Mar 03 '21 20:03 michael-hawker

Hey @nickrandolph - if you have time to get back to this please rebase the PR off of main, and ensure that you have no files being deleted/created, but only moved, if any. If you rebase in theory that should at least in part get fixed already, since all the backend viewmodels will have been moved to a separate project already 🙂

Sergio0694 avatar Mar 11 '21 00:03 Sergio0694

@nickrandolph was this still something you were interested in contributing this? I know a lot has changed between the prior split in this repo to have the separate .NET Standard project to facilitate code-share and then Uno itself with the TreeView in NavigationView support.

Wondering if it makes sense to revive this PR or start a new-one from the latest main branch.

michael-hawker avatar Nov 04 '21 20:11 michael-hawker

I'm guessing it probably makes sense to take a new branch of current main and add the Uno sample. I'll see whether I have capacity in the coming week

nickrandolph avatar Nov 07 '21 06:11 nickrandolph