CommunityToolkit
[Feature] Marquee Text Control
Adds a new MarqueeText control that scrolls text across the screen as a Marquee.
https://user-images.githubusercontent.com/9384045/190292642-e187f29e-8024-4906-bcb0-368544dafc85.mp4
@Avid29 Awesome work :)! FYI, I've added the win: prefix for FontStretch (as it's not supported for Uno) so that the build will hopefully pass!
So the current issue appears to be that in Uno (and only in Uno) Timeline is IDisposible, and therefore the MarqueeText control must also be IDisposible since it contains a Storyboard. However in UWP there's no reason to make the control IDisposible, so I'm really not tempted to just add that interface for no reason. For now, I have conditionally attached a IDisposible for Uno, but I'm not too happy with this solution.
Any better ideas?
@Avid29 was there a warning message about this or something somewhere calling this out?
@jeromelaban is this IDisposable message a red herring, are we missing something else instead?
Some objects are marked as disposable for internal constraints, but it's not something we can change right away as it may be a breaking change (we'll take note to add it as such for our next major). Having to add IDisposable here is likely a result of some analyzer that can be disabled for Uno targets specifically.
Hmm. That's frustrating. It fails with IDisposable because it's redundant, and it fails without IDisposible because it's missing...
Having to add IDisposable here is likely a result of some analyzer that can be disabled for Uno targets specifically.
@Avid29 See if you can find which analyzer is doing that. Since IDisposable is implemented as an internal constraint to Uno, we can effectively ignore this and disable the analyzer on uno platforms.
Having to add IDisposable here is likely a result of some analyzer that can be disabled for Uno targets specifically.
@Avid29 See if you can find which analyzer is doing that. Since
IDisposableis implemented as an internal constraint to Uno, we can effectively ignore this and disable the analyzer on uno platforms.
Partially fixed in #377, but since MarqueeText still owns the field, we need to manually suppress the error in this file. There's no way to suppress this problem globally for all files without sacrificing functionality.
@niels9001 I believe this is just waiting on your approval, right @Arlodotexe?
@niels9001 I believe this is just waiting on your approval, right @Arlodotexe?
2 minor comments.. otherwise looking great 😁! Awesome control!