CommandDash
Fix/exposed api key
PR related to issue: #207
currently covered case 2 : For old users - we can release a patch wherein we can write a script to extract a user's secret-key that is stored in the config and put it in secret storage and then delete it from the config.
@wadhia-yash Raising a PR for single case right now just to know if this changes are good enough and follows all rules as I didn't find much in contributions file. Please let me know if any suggestions.
Hi @yashpalzala, thanks. Skimmed through it and all looks good. Keep ensuring clean code and comments as you are already doing.
Look forward to the next iteration.
covered case 1: For new users - we already ask for the key in chat view. We need to save it to secret storage now instead of settings.
commit: 60b0acf
@yashpalzala we also made a directory shift recently to move everything in a /vscode folder since more platforms are going to be added soon.
Please take the latest pull at the earliest and we would be available to assist with any merge conflicts. thanks.
Hi @samyakkkk I have merged the latest changes from develop branch. Have also made changes acc. to new flow for getting api-key.
Regarding the 3rd case, do you have any specific flow in mind?
yes @yashpalzala, let's keep it simple. right by the clear chat button, let's add a profile button. Tapping on the profile button opens up profile edit page with a single option to update the API key.
please focus majorly on the functionality, the UI could be fixed by us later.
I'll also request to add tests if possible to ensure that all the three cases are working properly. Best.
Hi @samyakkkk I see the branch is not yet merged. Can I help you out with something?
Hi @yashpalzala, thanks for checking back. We are not able to ship this yet because we're yet to add the update api key functionality.
apologies for the delay! we will prioritise it again soon.
@samyakkkk looking forward to it, thanks @yashpalzala for working on it
@yashpalzala I really thank you for your work on this PR! unfortunately we're moving away from the BYOK model and are not asking users their Gemini key anymore.
I'm sorry we couldn't merge it for this reason.
interesting. what model are you using now, how do you avoid excessive costs or make back your costs please?
On Wed, Jul 3, 2024 at 4:59 AM Samyak Jain @.***> wrote:
@yashpalzala https://github.com/yashpalzala I really thank you for your work on this PR! unfortunately we're moving away from the BYOK model and are not asking users their Gemini key anymore.
I'm sorry we couldn't merge it for this reason.
— Reply to this email directly, view it on GitHub https://github.com/CommandDash/commanddash/pull/211#issuecomment-2205627768, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXBGYMTSMXUCP2AV2S3FR3ZKPDQ7AVCNFSM6AAAAABDE6CJ46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBVGYZDONZWHA . You are receiving this because you commented.Message ID: @.***>
We are using a revenue strategy to monetise SDK and API companies who will list on CommandDash. check plans we added today :D
Sounds super fantastic! Thank you 🙂
....sent from my phone
On Wed, Jul 3, 2024, 9:40 AM Samyak Jain @.***> wrote:
We are using a revenue strategy to monetise SDK and API companies who will list on CommandDash. check plans https://www.commanddash.io/#pricing we added today :D
— Reply to this email directly, view it on GitHub https://github.com/CommandDash/commanddash/pull/211#issuecomment-2206344154, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXBGYLY35M2M4SRGGEM6U3ZKQEMNAVCNFSM6AAAAABDE6CJ46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBWGM2DIMJVGQ . You are receiving this because you commented.Message ID: @.***>