Combodo
Debug log for invalid placeholders
This adds a debug log when a placeholder cannot be replaced.
This can happen for example in notifications, for a hyperlink() function for which we are specifying an invalid portal id : $this->hyperlink('non_existing_portal')$
Before the placeholder was just not replaced. Now we can enable a debug log on the LogChannels::NOTIFICATION channel.
Unfortunately the catch is done where we don't have the trigger / action context... But at least we will have more info than before !
During technical review, we wanted to see if it was possible not to call Debug() method when the level isn't enabled. Indeed it is... but starting from 3.0.0 only :/ The \LogAPI::IsLogLevelEnabled was added in that version with N°3731, and is already called when simply logging (in \LogAPI::WriteLog). So nothing to be done in 3.0.0, and if we want to limit the logs in 2.7 we should simply update the LogAPI class in that branch.
Sorry @piRGoif I just saw that comments from the last review where not submitted :/
Discussed during technical review ! We agreed to change the log level : use Error instead of Debug
Ideally we could replace the placeholder with the error message, but that should be done deeper in the call stack... Also, a specific behavior when beeing on a isDevEnv instance could be triggered ? For now we are ok on simply adding a log :)