CombineExt icon indicating copy to clipboard operation
CombineExt copied to clipboard

Implements DelaySubscription from #80

Open Jackstone92 opened this issue 4 years ago • 3 comments

Here is a first draft proposal for a Combine DelaySubscription operator for the request in #80. I would appreciate any thoughts and feedback!

Jackstone92 avatar Mar 07 '21 02:03 Jackstone92

Codecov Report

Merging #81 (3d7f4b6) into main (5b8a0c0) will decrease coverage by 0.35%. The diff coverage is 93.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   97.01%   96.66%   -0.36%     
==========================================
  Files          60       62       +2     
  Lines        3215     3594     +379     
==========================================
+ Hits         3119     3474     +355     
- Misses         96      120      +24     
Impacted Files Coverage Δ
Tests/DelaySubscriptionTests.swift 93.14% <93.14%> (ø)
Sources/Operators/DelaySubscription.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b8a0c0...64ba6e8. Read the comment docs.

codecov[bot] avatar Mar 07 '21 02:03 codecov[bot]

Really wicked! I’ll let @freak4pc chime in here, but for a related tangent, it’s neat to see how the PF duo pulled this off as a composed operator in https://github.com/pointfreeco/isowords/pull/94

jasdev avatar Apr 16 '21 18:04 jasdev

@jasdev To be honest I've found myself just using delay with flatMap instead of delaySubscription for quite a lot of times in Rx :)

Anyways, I'll try to dig into this a bit later. Thanks!

freak4pc avatar Apr 16 '21 18:04 freak4pc