Collapse icon indicating copy to clipboard operation
Collapse copied to clipboard
Published 3 weeks ago • verified publisher icon CollapseLauncher

[BEEG CHANGES] HoYoPlay API Adjustments

Open bagusnl opened this issue 1 year ago • 3 comments

Main Goal

  • Adjust Collapse for the new API provided from HoYoPlay (at least for the Hi3 Mainland China as of May 16th).
  • Use sophon installer for Genshin

PR Status :

  • Overall Status : In Progress
  • Commits : In Progress
  • Synced to base (Collapse:main) : Yes
  • Build status : OK
  • Crashing : No
  • Bug found caused by PR : unk

Templates

Changelog Prefixes 
  **[New]**
  **[Imp]**
  **[Fix]**
  **[Loc]**
  **[Doc]**

bagusnl avatar May 16 '24 01:05 bagusnl

Please note all of the changes here will be SQUASHED upon merge

bagusnl avatar May 16 '24 06:05 bagusnl

Also please ignore Qodana errors It doesnt like when you add new submodule, lol.

bagusnl avatar May 19 '24 11:05 bagusnl

Qodana for .NET

81 new problems were found

Inspection name Severity Problems
Conditional access qualifier expression is known to be null or not null 🔶 Warning 11
'??' condition is known to be null or not null 🔶 Warning 10
Possible 'System.NullReferenceException' 🔶 Warning 10
Explicit delegate creation expression is redundant 🔶 Warning 7
Redundant using directive 🔶 Warning 6
Conditional access qualifier expression is not null according to nullable reference types' annotations 🔶 Warning 5
Unused local variable 🔶 Warning 5
Async function without await expression 🔶 Warning 3
Expression is always 'true' or 'false' according to nullable reference types' annotations 🔶 Warning 3
Virtual member call in constructor 🔶 Warning 3
Possible 'null' assignment to non-nullable entity 🔶 Warning 2
'?:' expression has identical true and false branches 🔶 Warning 2
Assignment is not used 🔶 Warning 2
Redundant empty object or collection initializer 🔶 Warning 2
Do not use object initializer for 'using' variable 🔶 Warning 2
Access to disposed captured variable 🔶 Warning 1
Async method invocation without await expression 🔶 Warning 1
Invalid XML documentation comment 🔶 Warning 1
Mismatch of optional parameter value in overridden method 🔶 Warning 1
Redundant 'base.' qualifier 🔶 Warning 1
Redundant control flow jump statement 🔶 Warning 1
Variable in local function hides variable from outer scope 🔶 Warning 1
Missing grid column/row setter for non-first child 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Detected 100 dependencies

Third-party software list

This page lists the third-party software dependencies used in CollapseLauncher

Dependency Version Licenses
Clowd.Squirrel 2.11.1 MIT
CommunityToolkit.Common 8.2.2 MIT
CommunityToolkit.Mvvm 8.2.2 MIT
CommunityToolkit.WinUI.Animations 8.0.240109 MIT
CommunityToolkit.WinUI.Behaviors 8.0.240109 MIT
CommunityToolkit.WinUI.Controls.ImageCropper 8.1.240328-rc MIT
CommunityToolkit.WinUI.Controls.Primitives 8.0.240109 MIT
CommunityToolkit.WinUI.Controls.SettingsControls 8.0.240109 MIT
CommunityToolkit.WinUI.Controls.Sizers 8.0.240109 MIT
CommunityToolkit.WinUI.Converters 8.0.240109 MIT
CommunityToolkit.WinUI.Extensions 8.1.240328-rc MIT
CommunityToolkit.WinUI.Helpers 8.0.240109 MIT
CommunityToolkit.WinUI.Media 8.0.240109 MIT
CommunityToolkit.WinUI.Triggers 8.0.240109 MIT
GitInfo 3.3.5 MIT
Google.Protobuf.Tools 3.26.1 PROTOBUF
Google.Protobuf 3.26.1 BSD-3-Clause
Google.Protobuf 3.27.0 BSD-3-Clause
H.GeneratedIcons.System.Drawing 2.0.131 MIT
H.NotifyIcon.WinUI 2.0.131 MIT
H.NotifyIcon 2.0.131 MIT
Hi3Helper.ZstdNet 1.5.3 BSD-3-Clause
HtmlAgilityPack 1.11.61 MIT
ImageEx 2.1.1 MIT
Markdig.Signed 0.37.0 BSD-2-Clause
Microsoft.CSharp 4.7.0 MIT
Microsoft.Graphics.Win2D 1.2.0 MS-ASP-NET-WEB-OPTIMIZATION
Microsoft.NET.ILLink.Tasks 8.0.5 MIT
Microsoft.NETCore.Platforms 8.0.0-preview.7.23375.6 MIT
Microsoft.NETCore.Targets 6.0.0-preview.4.21253.7 MIT
Microsoft.Win32.Registry 5.0.0 MIT
Microsoft.Win32.SystemEvents 8.0.0 MIT
Microsoft.Windows.SDK.BuildTools 10.0.22621.3233 PROPRIETARY-LICENSE
Microsoft.WindowsAppSDK 1.5.240428000 MIT
MS-DXSDK-D3DX-9.29.952.3
Microsoft.Xaml.Behaviors.WinUI.Managed 2.0.9 MIT
PhotoSauce.MagicScaler 0.14.2 MIT
PhotoSauce.NativeCodecs.Libwebp 1.3.2-preview3 MIT
Roman-Numerals 2.0.0 MIT
SharpCompress 0.37.2 MIT
SharpHDiffPatch.Core 2.2.5 MIT
System.Collections.Concurrent 4.3.0 MS-NET-LIBRARY-2019-06
System.Collections 4.3.0 MS-NET-LIBRARY-2019-06
System.Diagnostics.Debug 4.3.0 MS-NET-LIBRARY-2019-06
System.Diagnostics.DiagnosticSource 4.3.0 MS-NET-LIBRARY-2019-06
System.Diagnostics.EventLog 8.0.0 MIT
System.Diagnostics.Tracing 4.3.0 MS-NET-LIBRARY-2019-06
System.Drawing.Common 8.0.5 MIT
System.Globalization.Calendars 4.3.0 MS-NET-LIBRARY-2019-06
System.Globalization.Extensions 4.3.0 MS-NET-LIBRARY-2019-06
System.Globalization 4.3.0 MS-NET-LIBRARY-2019-06
System.IO.FileSystem.Primitives 4.3.0 MS-NET-LIBRARY-2019-06
System.IO.FileSystem 4.3.0 MS-NET-LIBRARY-2019-06
System.IO.Hashing 8.0.0 MIT
System.IO 4.3.0 MS-NET-LIBRARY-2019-06
System.Linq 4.3.0 MS-NET-LIBRARY-2019-06
System.Net.Http 4.3.4 MS-NET-LIBRARY-2019-06
System.Net.Primitives 4.3.0 MS-NET-LIBRARY-2019-06
System.Reflection.Primitives 4.3.0 MS-NET-LIBRARY-2019-06
System.Reflection 4.3.0 MS-NET-LIBRARY-2019-06
System.Resources.ResourceManager 4.3.0 MS-NET-LIBRARY-2019-06
System.Runtime.Extensions 4.3.0 MS-NET-LIBRARY-2019-06
System.Runtime.Handles 4.3.0 MS-NET-LIBRARY-2019-06
System.Runtime.InteropServices 4.3.0 MS-NET-LIBRARY-2019-06
System.Runtime.Numerics 4.3.0 MS-NET-LIBRARY-2019-06
System.Runtime 4.3.1 MS-NET-LIBRARY-2019-06
System.Security.AccessControl 6.0.1 MIT
System.Security.Cryptography.Algorithms 4.3.0 MS-NET-LIBRARY-2019-06
System.Security.Cryptography.Cng 4.3.0 MS-NET-LIBRARY-2019-06
System.Security.Cryptography.Csp 4.3.0 MS-NET-LIBRARY-2019-06
System.Security.Cryptography.Encoding 4.3.0 MS-NET-LIBRARY-2019-06
System.Security.Cryptography.OpenSsl 4.3.0 MS-NET-LIBRARY-2019-06
System.Security.Cryptography.Primitives 4.3.0 MS-NET-LIBRARY-2019-06
System.Security.Cryptography.X509Certificates 4.3.0 MS-NET-LIBRARY-2019-06
System.Security.Principal.Windows 5.0.0 MIT
System.Text.Encoding.CodePages 8.0.0 MIT
System.Text.Encoding 4.3.0 MS-NET-LIBRARY-2019-06
System.Text.Encodings.Web 8.0.0 MIT
System.Text.Json 8.0.3 MIT
System.Text.RegularExpressions 4.3.1 MS-NET-LIBRARY-2019-06
System.Threading.Tasks.Extensions 4.5.4 MIT
System.Threading.Tasks 4.3.0 MS-NET-LIBRARY-2019-06
System.Threading 4.3.0 MS-NET-LIBRARY-2019-06
TaskScheduler 2.11.0 MIT
ThisAssembly.Constants 1.4.1 MIT
ZstdSharp.Port 0.8.1 MIT
runtime.debian.8-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.fedora.23-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.fedora.24-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.native.System.Net.Http 4.3.0 MS-NET-LIBRARY-2019-06
runtime.native.System.Security.Cryptography.Apple 4.3.0 MS-NET-LIBRARY-2019-06
runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.native.System 4.3.0 MS-NET-LIBRARY-2019-06
runtime.opensuse.13.2-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.opensuse.42.1-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.Apple 4.3.0 MS-NET-LIBRARY-2019-06
runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.rhel.7-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.ubuntu.14.04-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.ubuntu.16.04-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.ubuntu.16.10-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
Contact Qodana team

Contact us at [email protected]

  • Or via our issue tracker: https://jb.gg/qodana-issue
  • Or share your feedback: https://jb.gg/qodana-discussions

github-actions[bot] avatar May 23 '24 21:05 github-actions[bot]