saul icon indicating copy to clipboard operation
saul copied to clipboard
verified publisher icon CogComp

Name inconsistency

Open danyaljj opened this issue 9 years ago • 3 comments

We need to decide on these namings to bring more consistency to our code:

  • Learner vs Classifier ?
  • Train vs Learn ?
  • Save vs Write ?
  • Read vs Load ?

danyaljj avatar Apr 18 '16 23:04 danyaljj

Any reason not to stay with lbjava’s terminology as much as possible?

        Dan

From: Daniel Khashabi [mailto:[email protected]] Sent: Monday, April 18, 2016 6:15 PM To: IllinoisCogComp/saul Subject: [IllinoisCogComp/saul] Name inconsistency (#271)

We need to decide on these namings to bring more consistency to our code:

  • Learner vs Classifier ?
  • Train vs Learn ?
  • Save vs Write ?
  • Read vs Load ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_IllinoisCogComp_saul_issues_271&d=CwMCaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=EoEIPOcXriNKNTRQxPa5uv7hPypxUE6tE_RlGOluh-c&m=AG83foV3dsnjimqMMQaZGMBYsipV2DVKOA_iwUBTuPo&s=tB38LIGgvI-tNoM6T19Y5F4yF4wyi4welh_anFShQrM&e=

danr-ccg avatar Apr 20 '16 02:04 danr-ccg

I think we can improve it, though sometimes they have different functionalities like Learner and Classifier in LBJava and just to make it more clear different names are used here as well.

kordjamshidi avatar Apr 20 '16 03:04 kordjamshidi

Name change suggestions:

  • Learnable => Classifier
  • Learnable.classifier => Learnable.learner
  • ConstrainedInference => ConstrainedInferrer or Inferrer (More preferred)
  • LfsConstraint => Constraint

danyaljj avatar Apr 25 '16 20:04 danyaljj