saul icon indicating copy to clipboard operation
saul copied to clipboard

apply for Learnable calls only discrete value.

Open kordjamshidi opened this issue 9 years ago • 10 comments

Spotted by @onlinecco, when the regressor is called regressor(x) an NPE is thrown. For now the solution is that we should call it by saying explicitly regressor.realValue(x).

kordjamshidi avatar Feb 24 '16 22:02 kordjamshidi

What is a "regressor"?

danyaljj avatar Feb 24 '16 22:02 danyaljj

A Saul Learnable that does regression and returns a real value instead of class label.

kordjamshidi avatar Feb 24 '16 22:02 kordjamshidi

Do we have examples for regression?

danyaljj avatar Feb 24 '16 22:02 danyaljj

i added the biological example to Joey's fork. It is in the WebApp RP.

kordjamshidi avatar Feb 24 '16 22:02 kordjamshidi

Just for future reference, on regression Learners (which I don't know how many they are), realValue should be called, instead of discreteValue: example

danyaljj avatar Feb 24 '16 22:02 danyaljj

did you add any information here to what I said above?!

kordjamshidi avatar Feb 24 '16 22:02 kordjamshidi

I added the reference to the LBJava function which needs to be called, if someone wants to fix it in future.

danyaljj avatar Feb 24 '16 22:02 danyaljj

I already said we should call realValue and then we do not need to do anything with Lbjava we should just do a kind of type check/conversion in Saul when writing apply for Learnable.

kordjamshidi avatar Feb 24 '16 22:02 kordjamshidi

Good. Tnx.

danyaljj avatar Feb 24 '16 22:02 danyaljj

@onlinecco do you remember that we could train a regressor with multiple real properties? it seems it does not work now :(. We need a simple test for regression.

kordjamshidi avatar Feb 18 '17 03:02 kordjamshidi