Live-Poll icon indicating copy to clipboard operation
Live-Poll copied to clipboard

Adding options to the `qr-code` route

Open elunico opened this issue 4 years ago • 2 comments

After reading what @foxytocin said about the results page, I wanted to make things, hopefully a little more flexible.

First just to clarify, the QR code always brings you to the voting page for the newest poll regardless of what else is going on on the page.

What I did was changed it back so that the /qrcode route is now just going to deliver the QR code like before. I added a new query parameter results=boolean for only the /qrcode route. What this does is if you get /qrcode?results=true you will get the voting link QR code as normal plus the sidebar with the results of the poll included.

In addition, because of the concerns of foxytocin over OBS (which I really do not know how to work), I changed the iframe in the results + QR page to a pug include statement so that there is no iframe and the results.pug html gets included directly into the page. While I realize this may also not be optimal, since the results.pug is a full page complete with html root tags, etc., I want to propose this change first, and then, if it is well received, I could go and pull out the results code into a separate pug file and use it to render both pages with include directives.

elunico avatar Jun 16 '21 14:06 elunico

This is wonderful, @foxytocin I'd like to merge, let me know if you have any comments!

shiffman avatar Jul 06 '21 14:07 shiffman

@shiffman It's working but there are some deviations in the styling: As an example there are multiple headlines, with different stylings. Maybe that should be fixed accordingly to your needs for the streaming setup, after all the features are running smooth.

foxytocin avatar Jul 24 '21 08:07 foxytocin