neve icon indicating copy to clipboard operation
neve copied to clipboard

fix: expanded submenus on old skin

Open cristian-ungureanu opened this issue 3 years ago • 4 comments

Summary

Fixing the "Expand first level of dropdowns when menu is in mobile menu content." setting brakes the menus on legacy skin. This PR should fix the problem.

Will affect the visual aspect of the product

NO

Test instructions

  • On a fresh instance, install Neve 2.9, apply the starter content and add a new item to the header.
  • Update to the latest version, migrate the HFG
  • Switch to the legacy skin
  • Enable the "Expand first level of dropdowns when menu is in mobile menu content."
  • Check and see if submenus are expanded.
  • Check and see if the option still works on mobile
  • Check if "Expand first level of dropdowns when menu is in mobile menu content." option applies only to current instance

Closes #3619.

cristian-ungureanu avatar Sep 20 '22 15:09 cristian-ungureanu

Plugin build for bde963d5eb3a39e9308b6985ff039748aaa79ea3 is ready :bellhop_bell:!

github-actions[bot] avatar Sep 20 '22 15:09 github-actions[bot]

@cristian-ungureanu Tested and the issue is fixed, found something else though:

  • [x] Using the legacy skin, the dropdown caret isn't rotating anymore when i expand/hide the submenu. This happens when Neve pro is activated, if i deactivate it, it will work fine https://vertis.d.pr/w47SYe

Can be checked here:

 Admin area URL: https://legacy.s3-tastewp.com/wp-admin 
 Username: irinel 
 Password: ktiaT17fsvI 

irinelenache avatar Sep 21 '22 07:09 irinelenache

@irinelenache please check with this PR https://github.com/Codeinwp/neve-pro-addon/pull/2164

cristian-ungureanu avatar Sep 21 '22 09:09 cristian-ungureanu

@cristian-ungureanu Checked again and now everything's fine 🚀

irinelenache avatar Sep 21 '22 09:09 irinelenache

:tada: This PR is included in version 3.4.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

pirate-bot avatar Sep 27 '22 14:09 pirate-bot