module-rest icon indicating copy to clipboard operation
module-rest copied to clipboard

Show property name on failing JSON schema assertions

Open francislavoie opened this issue 1 year ago • 3 comments

Fixes https://github.com/Codeception/module-rest/issues/104

francislavoie avatar Jun 25 '24 19:06 francislavoie

@francislavoie I wonder if the tests could be adjusted to verify that the new logic works as expected.

This can be achieved by adjusting the expected exception messages in https://github.com/francislavoie/module-rest/blob/abc599a9992db4ed2d6f6165a6b3ad8fe901ae89/tests/unit/Codeception/Module/RestTest.php#L715. WDYT?

W0rma avatar Jul 11 '24 12:07 W0rma

Sorry for the wait, added a test @W0rma

francislavoie avatar Sep 17 '24 07:09 francislavoie

FYI @TavoNiievez just in case this got missed :pray:

francislavoie avatar Sep 23 '24 08:09 francislavoie

@W0rma @TavoNiievez Could we please merge this?

Every time I have schema failures in our tests, we're wasting lots of time to drill down to debug why the schema failed. This would save us so much time if you could merge this :pray:

francislavoie avatar Mar 06 '25 20:03 francislavoie

@francislavoie It seems that the tests are failing now. Can you verify why?

TavoNiievez avatar Mar 06 '25 20:03 TavoNiievez

Tests are failing on returnCallback but my PR does not touch that.

francislavoie avatar Mar 06 '25 20:03 francislavoie

Oh, okay thanks

TavoNiievez avatar Mar 06 '25 20:03 TavoNiievez

@TavoNiievez https://github.com/Codeception/module-rest/pull/113 should fix the tests.

It would be great if you could also merge https://github.com/Codeception/module-rest/pull/109 and tag a new release as proposed in https://github.com/Codeception/module-rest/issues/112

W0rma avatar Mar 06 '25 21:03 W0rma