docs icon indicating copy to clipboard operation
docs copied to clipboard

Dart Methods (New Pull Request)

Open brandk94 opened this issue 1 year ago • 6 comments

Description

  • Created a new sub-directory called 'methods' for the existing directory: 'content/dart/concepts'
  • Created and edited a new file called 'methods.md' for the directory: 'content/dart/concepts/methods'

Issue Solved

Closes #4252

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • [x] All writings are my own.
  • [x] My entry follows the Codecademy Docs style guide.
  • [x] My changes generate no new warnings.
  • [x] I have performed a self-review of my own writing and code.
  • [x] I have checked my entry and corrected any misspellings.
  • [x] I have made corresponding changes to the documentation if needed.
  • [x] I have confirmed my changes are not being pushed from my forked main branch.
  • [x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x] I have linked any issues that are relevant to this PR in the Issues Solved section.

brandk94 avatar Jun 20 '24 01:06 brandk94

Hi @cigar-galaxy82 and @ishg-153. I looked at the results of the commit push test and saw that the "ci (format:verify)" and "ci (test)" workflows failed. I looked to see what caused the failure, and for the "ci (test)" workflow, it turns out there was a spelling error with the "CatalogContent" metadata in the Dart methods.md file that I made. The word "Catalog" in "CatalogContent" was misspelled "Catelog", but now I fixed it to "Catalog". If there any more errors with this, please let me know. Thank you.

brandk94 avatar Jul 05 '24 23:07 brandk94

Hey @brandk94 Great! You don't need to worry about "ci (format:verify)" and "ci (test)", one of the maintainers will take care of it before merging the PR.

ishg-153 avatar Jul 11 '24 10:07 ishg-153

@cigar-galaxy82 Please are you working on reviewing this PR?

ishg-153 avatar Jul 11 '24 10:07 ishg-153

Change the structure of the of the entry as mentioned below

Syntax section Return Value section Parameters section

Then have a types of methods section, in this mention all the types shown below

Instance Method Static Method Short-Hand Method

cigar-galaxy82 avatar Aug 18 '24 14:08 cigar-galaxy82

Hi @brandk94 thank you for contributing to Codecademy docs, I have suggested changes please modify. Also please look at the structure of the entry is have suggested

cigar-galaxy82 avatar Aug 18 '24 20:08 cigar-galaxy82

Hi @cigar-galaxy82. I made significant changes to my Dart methods.md file in accordance with the suggested changes you requested, and some other changes to make the file context look nice and consistent. Please let me know what you think and if any further changes need to be made. Thank you.

brandk94 avatar Aug 20 '24 20:08 brandk94

👋 @brandk94 You have contributed to Codecademy Docs, and we would like to know more about you and your experience. Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners. Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/dart/methods

Please note it may take a little while for changes to become visible. If you're appearing as anonymous and want to be credited, see here.

github-actions[bot] avatar Sep 24 '24 15:09 github-actions[bot]