docs icon indicating copy to clipboard operation
docs copied to clipboard

Dart methods

Open brandk94 opened this issue 1 year ago • 1 comments

Description

  • Created a new sub-directory called 'methods' for the existing directory: 'content/dart/concepts'
  • Created and edited a new file called 'methods.md' for the directory: 'content/dart/concepts/methods'

Issue Solved

Closes #4252

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • [x] All writings are my own.
  • [x] My entry follows the Codecademy Docs style guide.
  • [x] My changes generate no new warnings.
  • [x] I have performed a self-review of my own writing and code.
  • [x] I have checked my entry and corrected any misspellings.
  • [x] I have made corresponding changes to the documentation if needed.
  • [x] I have confirmed my changes are not being pushed from my forked main branch.
  • [x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x] I have linked any issues that are relevant to this PR in the Issues Solved section.

brandk94 avatar Mar 03 '24 04:03 brandk94

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: ishg-153
:white_check_mark: dakshdeepHERE
:x: Brandon Kennedy


Brandon Kennedy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 03 '24 04:03 CLAassistant

Work on the initial comment @brandk94 then we will do the review for the content.

dakshdeepHERE avatar Mar 11 '24 15:03 dakshdeepHERE

@brandk94 Are still willing to work on this issue?

dakshdeepHERE avatar May 29 '24 14:05 dakshdeepHERE

Hello @dakshdeepHERE. I am still willing to do any more revised work on this issue. On March 11, I submitted a commit on my pull request containing the revised .md file for the "Dart methods" document, but I never got any response on whether it was approved for merging or needed to be worked on even further. Have you guys been able to receive it and has it been reviewed yet?

brandk94 avatar May 29 '24 23:05 brandk94

@brandk94 There seems to be an issue with the CLA. It might be that you have not configured your local bash/command line with the same email as your GitHub account. To fix this, please set up your git config email and username. Once done, create a new branch from your forks main and push this same file and create a new PR.

When you do let me know and we will take it from there. (After you create the new PR I will close this PR as stale).

ishg-153 avatar Jun 19 '24 07:06 ishg-153

Hi @ishg-153. I reconfigured my local Git Bash command line's email address and username to match the ones I have set in my GitHub account. I also created a new branch called "brandk94-dart-methods" on my forked repository that contains the most recent version of my "methods.md" file for the Dart section and I have also made a new Pull Request titled "Dart Methods (New Pull Request)" for that new branch. The link for it is: https://github.com/Codecademy/docs/pull/4796. Thus, I have resigned the CLA to hopefully fix the issue. If there are still any problems with this, please let me know. Thank You.

brandk94 avatar Jun 19 '24 18:06 brandk94

@brandk94 Great! Closing this PR as a duplicate.

ishg-153 avatar Jun 23 '24 07:06 ishg-153