vscode-gitignore icon indicating copy to clipboard operation
vscode-gitignore copied to clipboard

i18n: pull out strings in package.json

Open SethFalco opened this issue 4 years ago • 2 comments

This just pulls out some strings from the package.json file.

The name and description of the extension. The names/descriptions of the configuration values.

This makes it easy to translate them for other users.

The value for the description property should be added to package.nls.json and then referenced in the package.json file for localization support. - https://code.visualstudio.com/api/extension-guides/workspace-trust#static-declarations

I have another PR (https://github.com/CodeZombieCH/vscode-gitignore/pull/32) that will add a new setting if merged. When/if this gets merged, I can change that to use the package.nls.json as well.

Translations can be added by creating package.nls.{lang}.json files, such as package.nls.fr.json for French, the rest is handled by Visual Studio Code automatically.


Could I also propose changing gitignore extension configuration to either (in order of how much I like them):

  • Git Ignore
  • Gitignore
  • gitignore

The "extension" part is redundant because it's already in the "extension" section. And the "configuration" part is redundant because we're already in the VS Code settings.

image
You can see it looks a bit out of place there.

SethFalco avatar Jul 11 '21 00:07 SethFalco

Fixed conflicts, I also added a file here by accident that I was meant to do in a separate PR, but I guess it can stay. ^-^'

I wanted to add a CONTRIBUTING.md to just give a small intro on how to contribute to the repo, hope that's alright!

More Info: https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors

SethFalco avatar Jul 22 '22 13:07 SethFalco

Rebased with master and resolved merge conflicts.

SethFalco avatar Aug 30 '23 20:08 SethFalco