Igor Żuk comments

Results 132 comments of


                                            Igor Żuk

Add support for top level using for directive

I've tried running Slither using branch `dev-fix-usingfor` from PR https://github.com/crytic/slither/pull/1378 and indeed it doesn't throw the `Top level UsingForDirective not supported` anymore. Unfortunately it throws this strange exception: ``` 'forge...

Add support for top level using for directive

Thank you for looking into this! The codebase is here: https://github.com/radicle-dev/drips-contracts

Add support for top level using for directive

I've found the root issue. It turns out that Slither has a problem with the Foundry's test utils. Even the exception says that the problem was found in `lib/forge-std/src/Test.sol`. The...

Allow clearing storage and address warmness

Probably a duplicate of https://github.com/foundry-rs/foundry/issues/2429

Warn agains wrapping Logger in Logger::root in docs

I think that `impl Drain for Logger` is a very nice closure of idea of `Drain`s and in some cases it might add crucial elasticity. The depreciation could affect legitimate...

Ability to modify KV in Logger

Is it possible to create de-duplicating `Drain` with current API? AFAIK `Drain::log` receives `&OwnedKVList`, which can't do anything with its public API. This leads us back to my proposition 1,...

Ability to modify KV in Logger

So if I understand correctly, the idea is to create `Drain` which on every log will create a fake serializer and pass it to `KV`. This serializer will intercept and...

Ability to modify KV in Logger

I think that adding possibility to construct `OwnedKV` by hand could solve this issue. This is a simple newtype and a struct, so it would be 2 lines of code...

Ability to modify KV in Logger

Why `OwnedKVList` and not `OwnedKV`? The latter is more generic and can generate `OwnedKVList`, but not the other way around.

Allow mixedCase in the constants naming style

Hi @ekjotsinghmakhija, sorry, but I can't, I'm not a maintainer :shrug: