हिमांशु
हिमांशु
@ManyTheFish review if it looks fine then let me just do `cargo insta review` and then this PR can good to go
yes that is what i asking if impl. is fine then i just fix the test and fmt let me do both now
@ManyTheFish everything is passing i think it is good to go now
Not making it draft the this work will be complete by Monday
@ManyTheFish can you help me here adress what is wrong??
Hey @irevoire, Thanks for the review. I will do a rebase, then I will start working on it, but I have some things to do tomorrow, so I will start...
I see that your PR is merged so i am closing it but i will keep finding potential issues to work on thanks for review @irevoire Enjoy holidays!
> Hey, my pr is not solving the issue you were working on. You could totally rebase your pr on main if you wanted; I think you did a good...
@irevoire can you tell me that rebase is done or not I am bad at rebase if you can give me a confirmation that would be good
rebase is done and i am working on your reviews work will be done asap EDIT:- @irevoire I see there is a lot of mistakes that I made sorry for...