CodeGenieApp
bug: write method is not returning a boolean value
The implementation of the write method is missing a boolean return value indicating the need of drain https://github.com/CodeGenieApp/serverless-express/blob/mainline/src/response.js.
See https://nodejs.org/api/stream.html#writablewritechunk-encoding-callback
'The return value is true if the internal buffer is less than the highWaterMark configured when the stream was created after admitting chunk. If false is returned, further attempts to write data to the stream should stop until the 'drain' event is emitted.'
With newer versions of trpc (11.0.0-rc.419) this leads to a hang. The trpc middleware interprets void as false and waits for the 'drain' event that is never showing up. The lambda runtime is shutting down the event handling with an internal server error.
See https://github.com/trpc/trpc/blob/fbb4a2fb4b71d2f5ab7ee97617d951f3a92517c8/packages/server/src/adapters/node-http/nodeHTTPRequestHandler.ts#L85
In response.js the write method should return true.
See https://github.com/realityfilter/serverless-express-write-bugreport for a test case.
This might be enough? https://github.com/KATT/serverless-express/commit/9ba260ec7148d81a7caf2db84e62a1ba38b61925
Ran into this problem when packaging SvelteKit with adapter-node and polka, the effect confusingly caused the Lambda to return status code 200 with null as the body.
I can confirm that @KATT's fix provided does work, thanks!
Ran into this problem when trying to upgrade to Next.js 14.0.0. It also interprets void as falsey and waits for the stream 'drain' event that never happens. Patching my serverless-express version with this fix, solved the problem 👍
If someone wants to submit this as a PR I can merge it in @joshlperry @KATT
@brettstack I tried to make a PR originally but I lacked permissions and couldn't push up to create a remote branch, did I miss something? Happy to create a PR