CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard
verified publisher icon CodeEditApp

🐞 Changes to the color scheme are not applied in real-time

Open Qubik65536 opened this issue 3 years ago • 8 comments

Description

When we are changing the color scheme for a particular type of text, it does not change until we switch to another theme and switch it back.

To Reproduce

  1. Open CodeEdit
  2. Open a file with syntax highlighting
  3. Go to Settings, Themes
  4. Change the color scheme of a type of text (e.g. Keywords)
  5. Go back to the editor, the color doesn’t change
  6. Change to another theme
  7. Change back the theme
  8. The changed color is now applied

https://user-images.githubusercontent.com/72877496/212936994-db072044-9ba6-44e9-b726-4d652b031cd2.mp4

Expected behavior

When we change the color scheme, it should instantly apply.

Version information

CodeEdit: 78bf33e3b87b5d9ed04317e2e01936c4fd190571 macOS: 13.1 (22C65) Xcode: 14.1 (14B47b)

Additional context

N/A

Qubik65536 avatar Jan 17 '23 15:01 Qubik65536

Nice find! Color values should really be updating in real-time as the user changes them so they can get instant feedback.

austincondiff avatar Jan 18 '23 04:01 austincondiff

I was looking at these problems, and from what I can tell, there's just no function taking charge of the color scheme changes, so, the changes on the theme won't be applied to selectedTheme variable, so the only way to apply the changes has to change the theme and change it back (as the color value is applied, but the selectedTheme should be reloaded).

Qubik65536 avatar Jan 18 '23 16:01 Qubik65536

@Cubik65536- font updates are being handled in a PR that just merged into CodeEditTextView: https://github.com/CodeEditApp/CodeEditTextView/pull/122

You're right about the live color scheme changes needing some additional love to address..

ben-p-commits avatar Jan 18 '23 17:01 ben-p-commits

@Cubik65536 - can you modify the scope of this issue to remove the concern about fonts, to keep things tidy / separate?

ben-p-commits avatar Jan 18 '23 17:01 ben-p-commits

@Cubik65536 - can you modify the scope of this issue to remove the concern about fonts, to keep things tidy / separate?

I will do it later

Qubik65536 avatar Jan 18 '23 17:01 Qubik65536

@Cubik65536 - can you modify the scope of this issue to remove the concern about fonts, to keep things tidy / separate?

I did the modification and removed the concern about fonts.

Qubik65536 avatar Jan 18 '23 18:01 Qubik65536

@austincondiff - this rhymes with some of the stuff I did around line wrapping / misc text editor prefs. would be happy to nab this one.

ben-p-commits avatar Jan 24 '23 20:01 ben-p-commits

@ben-p-commits what is the status of this one?

austincondiff avatar Feb 16 '23 22:02 austincondiff