CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

✨ Use appropriate product icon for corresponding build type

Open austincondiff opened this issue 3 years ago • 7 comments

We should be using the correct icon depending on the build type.

Build type Product Icon Description
Local Development CodeEdit Dev Product Icon If you build locally we should use this icon.
Alpha CodeEdit Alpha Product Icon If you download a pre-release build from GitHub and until we go into beta, we should be using this icon.
Beta CodeEdit Beta Product Icon We will use this icon once in beta phase
Production CodeEdit Product Icon Only use this icon once we have a production release.

Note: Do not use the above image files as they are reduced in size for display on GitHub. The image files are already included in the project assets.

austincondiff avatar Jan 10 '23 16:01 austincondiff

Would just changing debug mode to be the local development icon and then release mode be the alpha suffice for now?

bombardier200 avatar Jan 10 '23 16:01 bombardier200

Preferable, only one icon set at a time should also be included in the app. Otherwise, they increase the build size quite a bit

Wouter01 avatar Jan 10 '23 16:01 Wouter01

@Wouter01 Absolutely! This will definitely help our bundle size.

austincondiff avatar Jan 10 '23 16:01 austincondiff

@Wouter01 Absolutely! This will definitely help our bundle size.

I'm wondering if this should be done using CICD?

Wouter01 avatar Jan 10 '23 16:01 Wouter01

Not a bad idea. I would assume so.

austincondiff avatar Jan 10 '23 16:01 austincondiff

@lukepistrol, what's your opinion on this?

Wouter01 avatar Jan 10 '23 16:01 Wouter01

I can work something out using configurations in Xcode later today/tomorrow

lukepistrol avatar Jan 10 '23 16:01 lukepistrol