CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

🚨 Move Components to Modules

Open lukepistrol opened this issue 3 years ago • 3 comments

We should try to move all existing components which live in the main target as of now to their own modules in CodeEditModules.

This would increase testability and structure of the code.

In particular we should do this for:

  • [ ] Documents (most important & requirement for all others)
  • [x] Welcome
  • [x] Settings
  • [x] Breadcrumbs
  • [ ] Extensions
  • [ ] TabBar
  • [ ] NavigatorSidebar
  • [ ] InspectorSidebar
  • [x] QuickOpen

In addition all new components should only live inside CodeEditModules except there is a specific enough reason not to do so.

lukepistrol avatar Mar 24 '22 17:03 lukepistrol

I think we need to modularize WorkspaceDocument first and then we are able to modularize other UI components because some of them (e.g. TabBar) are highly relying on the workspace document.

lilingxi01 avatar May 03 '22 16:05 lilingxi01

Are we going to modularize the whole thing? Like, what is going to stay in the app itself?

matthijseikelenboom avatar Oct 06 '22 21:10 matthijseikelenboom

@lilingxi01 How exactly were you planning on doing this? I see what you are saying. I am trying to move TabBar into it's own module and I am getting cyclic dependency declaration found errors.

@matthijseikelenboom I think we should handle window management and application setup in the main app. Anyone else have any thoughts here?

austincondiff avatar Oct 11 '22 06:10 austincondiff

Closing as it is no longer applicable.

austincondiff avatar Feb 14 '23 05:02 austincondiff