🐞 Open Quickly Overlay - The vertical separator should be the same color as the horizontal separator

[austincondiff]

Describe the bug The vertical separator in the open quickly overlay doesn't match the horizontal one.

Expected behavior Change the vertical separator to match the horizontal one.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[thecoolwinter]

I think this can be closed, these looks like the same color to me.

[nrudnyk]

@thecoolwinter not really, looks that the problem still exist for the dark theme

[nrudnyk]

moreover, there's much more important problem here

https://user-images.githubusercontent.com/20221382/172391618-2f8d5890-e319-4c8a-bbd6-5afc1d31604e.mov

maybe for the simplicity there's no need in previewing files? @lukepistrol @wdg what do you think?

[0xWDG]

Xcode does only show a list iirc. for me it's ok to only show an list.

@austincondiff what do you think about this, you are better with the design :)

[nrudnyk]

while file preview is cool (mos likely it is, plus it's useful), there's some cons to it:

• it's already a little laggy previewing those files (maybe will be better with tree-sitter)
• there's color issues caused by split view vs divider (which could be omitted altogether)
• resizing splitter is awkward
• and the last one - default size won't fit all files and name will be cut

just a few points for consideration. Sorry for bringing this up (maybe that's the wrong place)

[austincondiff]

I'd prefer it with the preview, but if we include it, it needs to be fast. I believe we can get there with the new editor view.

It shouldn't be resizable and the vertical border color should match the input's bottom border.

[thecoolwinter]

The preview is also loading the entire file. We could definitely speed it up by just reading the first few lines and displaying them for the preview. Unless ofc we want it to be scrollable.

[austincondiff]

It should be scrollable and should use the same editor view @lukepistrol is working on. This should speed up performance.

[austincondiff]

As in Xcode, there will be a toggle to turn on and off this preview at the top right of the overlay.

Clicking this toggle, changes the symbols appearance and hides the preview as shown below.

This is out of scope of this particular issue so I will go ahead and create another with the above adjustments, but the divider should be a simple separator and should not resize the split when dragged.