CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

Developer settings menu

Open FastestMolasses opened this issue 1 year ago • 5 comments

Description

This PR adds a settings menu for developers to add LSP binaries. Currently, this settings menu is intended to be removed before 1.0 releases, unless we would like a generalized 'dev' settings menu, for CodeEdit developers. This PR is needed before we can merge the LSP backend into the main branch.

Related Issues

Closes #1732

Checklist

  • [x] I read and understood the contributing guide as well as the code of conduct
  • [x] The issues this PR addresses are related to each other
  • [x] My changes generate no new warnings
  • [x] My code builds and runs on my machine
  • [x] My changes are all related to the related issue above
  • [x] I documented my code

Screenshots

Screenshot 2024-05-23 at 5 17 56 AM

FastestMolasses avatar May 23 '24 12:05 FastestMolasses

You could rename this settings pane to be developer to be more generic and then add a section title “LSP binaries” above the table. Maybe this settings pane appears when you hit a certain key five times or something.

austincondiff avatar May 23 '24 12:05 austincondiff

Screenshot 2024-05-23 at 10 29 00 AM Screenshot 2024-05-23 at 10 29 09 AM

Here's what it currently looks like

FastestMolasses avatar May 23 '24 17:05 FastestMolasses

Maybe this settings pane appears when you hit a certain key five times or something.

What about using F12 to toggle the dev menu? Similar to the dev menu in browsers.

FastestMolasses avatar May 23 '24 17:05 FastestMolasses

You might wrap the two inputs in a Form with a .formStyle(.grouped) modifier.

austincondiff avatar May 24 '24 03:05 austincondiff

Here is the new modal with the .formStyle(.grouped) modifier:

Screenshot 2024-05-23 at 11 26 40 PM

Here is the functionality of showing / hiding the developer menu with F12:

https://github.com/CodeEditApp/CodeEdit/assets/29493784/7e6c30e9-e317-447e-919d-1a35f9016b0a

FastestMolasses avatar May 24 '24 06:05 FastestMolasses

It should look like this… image There should also be a delete button. You can refer to SourceControlNavigatorNewBranchView.

austincondiff avatar May 24 '24 18:05 austincondiff

Updated the style

Screenshot 2024-05-25 at 12 10 40 AM

FastestMolasses avatar May 25 '24 06:05 FastestMolasses