codechain icon indicating copy to clipboard operation
codechain copied to clipboard

Tracker method calling part needs to be refactored

Open HoOngEe opened this issue 6 years ago • 0 comments

Now the tracker() method can be called through the structs ShardTransaction, Action and Transaction.

Some caller function code is now using useless conversion from Action to ShardTransaction though the conversion was already implemented inside of the tracker() of Action. As well as the above, after the pr#1548, the implementations will become inconsistent. Previously the tracker was needed only for asset transactions, but now the WrapCCC needs tracker though it's not an asset transaction.

From this semantic inconsistency, there is an implementation gap between tracker() of Action and the others. Therefore, the refactoring needs for tracker() and related caller functions not to be confused in the future.

HoOngEe avatar May 21 '19 06:05 HoOngEe