BulletBot icon indicating copy to clipboard operation
BulletBot copied to clipboard

Unlock command bug

Open StrangeRanger opened this issue 6 years ago • 0 comments

Describe the bug If a channel that only has disabled permissions (❌) OR has a mix of disabled and neutral permissions (❌ & /), is locked using ?!lock #channel, then unlocked using ?!unlock #channel, will result in the permissions of that channel NOT persisting/going back to what way they were before being locked. Rather, all the permissions of that channel are reset to the neutral state (/). (THIS PART IS THE BUG) (BELOW IS JUST MORE INFO ON SOME THINGS THAT I’VE FOUND, WHEN TRYING TO IDENTIFY THIS BUG. EVEN THOUGH THEY ARENT APART OF THE BUG ITSELF, I HIGHLY RECOMMEND YOU READ IT TO GET BETTER UNDERSTANDING...)

Though if a channel that has a mix of enabled and disabled permissions (❌ & ✅) OR a mix of all three permissions (✅ & ❌ & /) OR a mix of enabled and neutral permissions (✅ & /) OR only enabled permissions (✅), is locked using ?!lock #channel, then unlocked using ?!unlock #channel, will result in the permissions of that channel persisting; they will go back to the way the were before being locked. In Both of these situations/cases (the two above), the permission"Send Messages" must be neutral (/).

If the channel was locked using a timer (?!lock #channel 30min), and the channel were unlocked after the timer was done, the channel's permissions would persist; return to the way they were before it was locked. It doesn't matter what configuration of disable, enabled, or netrual permissions you had before locking the channel. No matter what, the permission from before locking the channel, will persist. If the "Send Messages" permission is either disabled (❌) or enabled (✅) (anything but neutral /), when that channel is locked using ?!lock #channel, then unlocked with ?!unlock #channel, the channel's permission before being locked will persist; return to normal. Just like above, it doesn't matter what configuration of permissions you have on that channel. All that matters is that the "'Send Messages' permission is either disabled (❌) or enabled (✅) (anything but neutral /)". This configuration and outcome occures even when a timer is used (?!lock #channel 30min).

To Reproduce Steps to reproduce the behavior: The steps are given above, in the description of the bug.

Expected behavior To unlock the channel without resetting all of the permissions, rather only return the “Send Messages” permission to the way it was before being locked.

Setup (please complete the following information):

  • OS: Ubuntu
  • Node.js Version: 13.X
  • MongoDB Version: 4.2.X
  • Release Version 1.2.8

StrangeRanger avatar Dec 21 '19 21:12 StrangeRanger