carnac icon indicating copy to clipboard operation
carnac copied to clipboard

Upgrade project files to newer format

Open shiftkey opened this issue 5 years ago • 0 comments

This PR leverages CsprojToVs2017 to do the heavy lifting of upgrading to the newer project format that VS2017 and above support, which also gives us <PackageReference> elements to support Dependabot updates in the future (replaces packages.config). This will still generate a net45 app but will help with ongoing maintenance and potential updates in the future, given net45 is no longer officially supported by Microsoft.

This also required updating Fody and related Fody projects to the latest version, but I think that's a good thing as there are some warnings to investigate about things we might have done wrong in the past

TODO:

  • [x] confirm build passes
  • [x] review build warnings
  • [x] address Unsupported signature for a On_PropertyName_Changed method: OnLeftChanged in Carnac.Logic.Models.PopupSettings
  • [x] address Could not find rule set file "MinimumRecommendedRules.ruleset".
  • [ ] test app locally and confirm no unexpected issues

shiftkey avatar Jun 20 '20 17:06 shiftkey