code.mil icon indicating copy to clipboard operation
code.mil copied to clipboard

Footer Email Reference

Open TangoYankee opened this issue 7 years ago • 4 comments

Feature

Increase maintainability of references in footer

Affected Area

footer, lines 58 & 59

Description

'href' for email uses a liquid reference to the configuration file. However, the associated 'text' is hard-coded. hard-coding could be replaced with:

'{{site.email}}'

TangoYankee avatar Jul 15 '18 14:07 TangoYankee

Note this works for ruby version 2.3. It may break for 2.5

TangoYankee avatar Jul 16 '18 23:07 TangoYankee

Hey @TangoYankee ! Thanks for the report. I think I recall trying to do this at one point and it not working for some reason. That said, if it works, we should do it! PRs welcome. ;)

jordangov avatar Oct 04 '18 20:10 jordangov

I believe this is resolved and should be closed? Is that true?

tinjaw avatar Aug 26 '20 23:08 tinjaw

https://github.com/Code-dot-mil/code.mil/blob/e3060542de6125c6ba5a0f1c61c882b307330948/src/_data/footer.yml#L59

Agreed

zacnomore avatar Sep 21 '20 20:09 zacnomore