Dark theme

[frostius]

Any chance of a dark theme?

[Mabus13]

Yep yep yep!!! I want it tooooooooooooooo ^_________^

[janwilmans]

I will investigate, but I fear the worst, I never took application specific themes into account when we started this project, so the theme changes with the windows theme. Also, I am trying to focus my time to debug.vision a next generation version of debugview++, so maybe we can do something there.

[frostius]

The ability to change the font color and log background would be a big improvement if a true dark theme is not feasible.

This is the only development app I use that doesn't have a dark mode. At night when the room is dark, its like a spotlight shining out of my monitor.

[janwilmans]

good idea, I guess to work also need to persist this option?

On Thu, Apr 29, 2021, 15:22 Matt Frost @.***> wrote:

The ability to change the font color and log background would be a big improvement if a true dark theme is not feasible.

This is the only development app I use that doesn't have a dark mode. At night when the room is dark, its like a spotlight shining out of my monitor.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829233482, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNITBBGHCIENYZ4NGSB2LLTLFMSXANCNFSM43WBCCLQ .

[frostius]

For sure, theme persistence would be nice. On that note, persisting the screen location/dimensions would be a nice-to-have as well.

------ Original Message ------ From: "Jan Wilmans" @.> To: "CobaltFusion/DebugViewPP" @.> Cc: "Matt Frost" @.>; "Author" @.> Sent: 4/29/2021 9:36:03 AM Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368)

good idea, I guess to work also need to persist this option?

On Thu, Apr 29, 2021, 15:22 Matt Frost @.***> wrote:

The ability to change the font color and log background would be a big improvement if a true dark theme is not feasible.

This is the only development app I use that doesn't have a dark mode. At night when the room is dark, its like a spotlight shining out of my monitor.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub

https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829233482,

or unsubscribe

https://github.com/notifications/unsubscribe-auth/ABNITBBGHCIENYZ4NGSB2LLTLFMSXANCNFSM43WBCCLQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829243468, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5EK4WRGRACMJUF2K5XCNDTLFOEHANCNFSM43WBCCLQ.

[janwilmans]

I should already persist the screen location? doesn't it?

On Thu, Apr 29, 2021, 16:44 Matt Frost @.***> wrote:

For sure, theme persistence would be nice. On that note, persisting the screen location/dimensions would be a nice-to-have as well.

------ Original Message ------ From: "Jan Wilmans" @.> To: "CobaltFusion/DebugViewPP" @.> Cc: "Matt Frost" @.>; "Author" @.> Sent: 4/29/2021 9:36:03 AM Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368)

good idea, I guess to work also need to persist this option?

On Thu, Apr 29, 2021, 15:22 Matt Frost @.***> wrote:

The ability to change the font color and log background would be a big improvement if a true dark theme is not feasible.

This is the only development app I use that doesn't have a dark mode. At night when the room is dark, its like a spotlight shining out of my monitor.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub

< https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829233482 ,

or unsubscribe

< https://github.com/notifications/unsubscribe-auth/ABNITBBGHCIENYZ4NGSB2LLTLFMSXANCNFSM43WBCCLQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829243468>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA5EK4WRGRACMJUF2K5XCNDTLFOEHANCNFSM43WBCCLQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829298825, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNITBALAC25C7OMXEA45OLTLFWF5ANCNFSM43WBCCLQ .

[frostius]

Sometimes the size is persisted but never the location. Tested just now, and no persistence at all in 5 close/open cycles.

I'm running Win10 on an external 4K monitor. The laptop screen is closed/disabled.

------ Original Message ------ From: "Jan Wilmans" @.> To: "CobaltFusion/DebugViewPP" @.> Cc: "Matt Frost" @.>; "Author" @.> Sent: 4/29/2021 2:24:09 PM Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368)

I should already persist the screen location? doesn't it?

On Thu, Apr 29, 2021, 16:44 Matt Frost @.***> wrote:

For sure, theme persistence would be nice. On that note, persisting the screen location/dimensions would be a nice-to-have as well.

------ Original Message ------ From: "Jan Wilmans" @.> To: "CobaltFusion/DebugViewPP" @.> Cc: "Matt Frost" @.>; "Author" @.> Sent: 4/29/2021 9:36:03 AM Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368)

good idea, I guess to work also need to persist this option?

On Thu, Apr 29, 2021, 15:22 Matt Frost @.***> wrote:

The ability to change the font color and log background would be a big improvement if a true dark theme is not feasible.

This is the only development app I use that doesn't have a dark mode. At night when the room is dark, its like a spotlight shining out of my monitor.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub

<

https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829233482

,

or unsubscribe

<

https://github.com/notifications/unsubscribe-auth/ABNITBBGHCIENYZ4NGSB2LLTLFMSXANCNFSM43WBCCLQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829243468>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AA5EK4WRGRACMJUF2K5XCNDTLFOEHANCNFSM43WBCCLQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub

https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829298825,

or unsubscribe

https://github.com/notifications/unsubscribe-auth/ABNITBALAC25C7OMXEA45OLTLFWF5ANCNFSM43WBCCLQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829487244, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5EK4SOATPC6URIO252WFTTLGP4TANCNFSM43WBCCLQ.

[janwilmans]

I'm looking at this, because I remember there was a bug where the window could go/reopen at an off screen location if it was last closed with 2 monitors attached and reopened with only one.

I not sure I can reliably detect this case.

On Thu, Apr 29, 2021, 21:11 Matt Frost @.***> wrote:

Sometimes the size is persisted but never the location. Tested just now, and no persistence at all in 5 close/open cycles.

I'm running Win10 on an external 4K monitor. The laptop screen is closed/disabled.

------ Original Message ------ From: "Jan Wilmans" @.> To: "CobaltFusion/DebugViewPP" @.> Cc: "Matt Frost" @.>; "Author" @.> Sent: 4/29/2021 2:24:09 PM Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368)

I should already persist the screen location? doesn't it?

On Thu, Apr 29, 2021, 16:44 Matt Frost @.***> wrote:

For sure, theme persistence would be nice. On that note, persisting the screen location/dimensions would be a nice-to-have as well.

------ Original Message ------ From: "Jan Wilmans" @.> To: "CobaltFusion/DebugViewPP" @.> Cc: "Matt Frost" @.>; "Author" @.> Sent: 4/29/2021 9:36:03 AM Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368)

good idea, I guess to work also need to persist this option?

On Thu, Apr 29, 2021, 15:22 Matt Frost @.***> wrote:

The ability to change the font color and log background would be a big improvement if a true dark theme is not feasible.

This is the only development app I use that doesn't have a dark mode. At night when the room is dark, its like a spotlight shining out of my monitor.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub

<

https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829233482

,

or unsubscribe

<

https://github.com/notifications/unsubscribe-auth/ABNITBBGHCIENYZ4NGSB2LLTLFMSXANCNFSM43WBCCLQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829243468

,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AA5EK4WRGRACMJUF2K5XCNDTLFOEHANCNFSM43WBCCLQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub

< https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829298825 ,

or unsubscribe

< https://github.com/notifications/unsubscribe-auth/ABNITBALAC25C7OMXEA45OLTLFWF5ANCNFSM43WBCCLQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829487244>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA5EK4SOATPC6URIO252WFTTLGP4TANCNFSM43WBCCLQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829516908, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNITBHZYC3XC4V7JF2UG3TTLGVODANCNFSM43WBCCLQ .

[frostius]

This is not that case. I'm just opening and closing on a single monitor. Send me a debug version and I'd be happy to post the log.

On Thu, Apr 29, 2021, 7:03 PM Jan Wilmans @.***> wrote:

I'm looking at this, because I remember there was a bug where the window could go/reopen at an off screen location if it was last closed with 2 monitors attached and reopened with only one.

I not sure I can reliably detect this case.

On Thu, Apr 29, 2021, 21:11 Matt Frost @.***> wrote:

Sometimes the size is persisted but never the location. Tested just now, and no persistence at all in 5 close/open cycles.

I'm running Win10 on an external 4K monitor. The laptop screen is closed/disabled.

------ Original Message ------ From: "Jan Wilmans" @.> To: "CobaltFusion/DebugViewPP" @.> Cc: "Matt Frost" @.>; "Author" @.> Sent: 4/29/2021 2:24:09 PM Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368)

I should already persist the screen location? doesn't it?

On Thu, Apr 29, 2021, 16:44 Matt Frost @.***> wrote:

For sure, theme persistence would be nice. On that note, persisting the screen location/dimensions would be a nice-to-have as well.

------ Original Message ------ From: "Jan Wilmans" @.> To: "CobaltFusion/DebugViewPP" @.> Cc: "Matt Frost" @.>; "Author" @.> Sent: 4/29/2021 9:36:03 AM Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368)

good idea, I guess to work also need to persist this option?

On Thu, Apr 29, 2021, 15:22 Matt Frost @.***> wrote:

The ability to change the font color and log background would be a big improvement if a true dark theme is not feasible.

This is the only development app I use that doesn't have a dark mode. At night when the room is dark, its like a spotlight shining out of my monitor.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub

<

https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829233482

,

or unsubscribe

<

https://github.com/notifications/unsubscribe-auth/ABNITBBGHCIENYZ4NGSB2LLTLFMSXANCNFSM43WBCCLQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829243468

,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AA5EK4WRGRACMJUF2K5XCNDTLFOEHANCNFSM43WBCCLQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub

<

https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829298825

,

or unsubscribe

<

https://github.com/notifications/unsubscribe-auth/ABNITBALAC25C7OMXEA45OLTLFWF5ANCNFSM43WBCCLQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829487244

,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AA5EK4SOATPC6URIO252WFTTLGP4TANCNFSM43WBCCLQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829516908 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABNITBHZYC3XC4V7JF2UG3TTLGVODANCNFSM43WBCCLQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CobaltFusion/DebugViewPP/issues/368#issuecomment-829651233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5EK4SSO2VV64S4ZT5FWK3TLHQT7ANCNFSM43WBCCLQ .

[janwilmans]

I just tested this, but the latest version https://github.com/CobaltFusion/DebugViewPP/releases restores the position correctly here, even over different monitors, it shows back up at the correct position, on the same monitor I used it on.

Can you send me a screenshot of the 'about' window of your debugview++ ?

[Mabus13]

Any new version with dark theme soon?

[janwilmans]

I have more pressing work planned, so unless I get a pull request, not any time soon...

[Mabus13]

Pity. Wish you easy coding and more free time. ^___^

[smallscript]

🦜 I'd love it as well ^__^

Anyone have some notes or a summary of areas to look at in the code-base?

[Mabus13]

🦜 I'd love it as well ^__^

Anyone have some notes or a summary of areas to look at in the code-base?

LRESULT CMainFrame::OnCreate(const CREATESTRUCT* /pCreate/) in MainFrame.cpp i looked here but also have not time to finish that feature...