pcs icon indicating copy to clipboard operation
pcs copied to clipboard

add support for openrc

Open tomjelinek opened this issue 3 years ago • 4 comments

resolves #266

tomjelinek avatar Apr 07 '22 15:04 tomjelinek

checking for GNU default python exec_prefix... ${exec_prefix} checking for python script directory (pythondir)... ${PYTHON_PREFIX}/lib/python3.9/site-packages checking for python extension module directory (pyexecdir)... ${PYTHON_EXEC_PREFIX}/lib/python3.9/site-packages checking for systemd... no configure: error: Package requirements (systemd) were not met:

Package 'systemd', required by 'virtual:world', not found

Consider adjusting the PKG_CONFIG_PATH environment variable if you installed software in a non-standard prefix.

Alternatively, you may set the environment variables systemd_CFLAGS and systemd_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details.

with your patch the systemd check blocks configure

custom82 avatar Apr 08 '22 09:04 custom82

@custom82 So there is this nice patch https://github.com/gentoo/guru/blob/master/sys-cluster/pcs/files/pcs-0.11-gentoo-support.patch fixing probably all the OpenRC and Gentoo related issues. Why don't you take it a bit further and submit it as a pull request?

tomjelinek avatar Apr 28 '22 10:04 tomjelinek

I really trusted a lot in your patch, our patch written by me and Alessandro Barbieri we don't know how functional it is.

custom82 avatar Apr 30 '22 18:04 custom82

@custom82

Well, we have virtually no knowledge of and experience with Gentoo. So if you are able to patch pcs to make it work on Gentoo (which according to the patch you are) and you have access to Gentoo machines to test it, then you already have a big advantage.

Not only you wrote openrc driver including tests, you also fixed pam config. Your patch is a great start and only needs a bit of polishing. Mainly, make systemd detection optional instead of removing it. Also, it would be great if replacing localstatedir variable with /var could somehow be resolved. Isn't localstatedir equal to /var on Gentoo?

It would really make it easier for us if you submitted you patch in a pull request.

tomjelinek avatar May 02 '22 13:05 tomjelinek