pcs icon indicating copy to clipboard operation
pcs copied to clipboard

Add page related I18N

Open Jaycean opened this issue 5 years ago • 3 comments

  • Using Ruby I18N package:ruby-i18n
  • Completed the I18N work related to Ruby on the page, and will improve the I18N work related to JS in the future

Jaycean avatar Sep 05 '20 08:09 Jaycean

  • PR failed the regression test with the following error message
  • After looking at the process of regression testing, I found that the regression test did not update the gem package, which resulted in the failure of I18N new dependency. Therefore, I would like to ask whether the regression test process updates the gem package? It seems that the package is installed in the basic image of regression test. If so, do you need to update the basic image to pass the regression test
The command "docker run $DIST make -C $SRC_PATH black_check" exited with 0.
0.95s$ docker run -e "GEM_HOME=$GEM_HOME" $DIST $RUBY_BIN -I $SRC_PATH/pcsd -I $SRC_PATH/pcsd/test $SRC_PATH/pcsd/test/test_all_suite.rb
/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:83:in `require': cannot load such file -- i18n (LoadError)
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/share/gems/gems/backports-3.17.1/lib/backports/std_lib.rb:12:in `require_with_backports'
	from /src/pcs/pcsd/config.rb:5:in `<top (required)>'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/share/gems/gems/backports-3.17.1/lib/backports/std_lib.rb:12:in `require_with_backports'
	from /src/pcs/pcsd/pcs.rb:16:in `<top (required)>'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /src/pcs/pcsd/cluster_entity.rb:2:in `<top (required)>'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /src/pcs/pcsd/test/test_cluster_entity.rb:8:in `<top (required)>'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /src/pcs/pcsd/test/test_all_suite.rb:6:in `<main>'
The command "docker run -e "GEM_HOME=$GEM_HOME" $DIST $RUBY_BIN -I $SRC_PATH/pcsd -I $SRC_PATH/pcsd/test $SRC_PATH/pcsd/test/test_all_suite.rb" exited with 1.

Jaycean avatar Sep 07 '20 01:09 Jaycean

Thank you for your PR. Adding a new rubygem isn't really a straightforward process so I did it for you in this commit: https://github.com/ondrejmular/pcs/commit/baafee9f78f742e0c39d5f3b43d42b6e6d9e6027

So far we haven't had time to look at the code of the PR yet. I hope we'll be able to do so in the following weeks.

ondrejmular avatar Sep 24 '20 12:09 ondrejmular

no problem

Jaycean avatar Sep 26 '20 02:09 Jaycean