pacemaker icon indicating copy to clipboard operation
pacemaker copied to clipboard

t176

Open waltdisgrace opened this issue 2 years ago • 4 comments

waltdisgrace avatar Jan 17 '24 15:01 waltdisgrace

Changed my mind on validate vs verify, updated comment :)

kgaillot avatar Jan 17 '24 17:01 kgaillot

Seeing the XML output reminds me that I forgot the schema portion of the crm_verify project :/ I'll open a new task for that ...

kgaillot avatar Feb 01 '24 15:02 kgaillot

Seeing the XML output reminds me that I forgot the schema portion of the crm_verify project :/ I'll open a new task for that ...

Actually, crm_verify XML output only has status and errors, so it fits in the existing schemas. So, all we need to do is update the crm_mon schema for this project once it's ready.

kgaillot avatar Feb 01 '24 15:02 kgaillot

Add crm_mon regression tests -- you can use one of the crm_verify_invalid*xml files to test invalid syntax and crm_mon.xml to test valid syntax. Test text and XML for each using defaults, and also test --include=verifications for text+valid and --exclude=verifications for XML+invalid

Actually we have plenty of text/XML + valid tests, so we just need to add tests for invalid and --include/--exclude

kgaillot avatar Mar 18 '24 17:03 kgaillot

This should be revisited at some point (probably after T873, T882, and T727), but the code base has changed significantly enough to close this for now and open a new PR then.

kgaillot avatar Dec 04 '24 17:12 kgaillot