CloudBotLegacy icon indicating copy to clipboard operation
CloudBotLegacy copied to clipboard

Add client_id to requests

Open case opened this issue 11 years ago • 5 comments

case avatar Jun 19 '14 05:06 case

What is the benefit of adding this?

-- Above message was sent from my mobile phone. There may and will be all kinds of errors included. For free! On 19 Jun 2014 07:19, "Eric Case" [email protected] wrote:


You can merge this Pull Request by running

git pull https://github.com/case/CloudBot patch-1

Or view, comment on, or merge it at:

https://github.com/ClouDev/CloudBot/pull/290 Commit Summary

  • Add client_id to requests

File Changes

  • M plugins/domainr.py https://github.com/ClouDev/CloudBot/pull/290/files#diff-0 (2)

Patch Links:

  • https://github.com/ClouDev/CloudBot/pull/290.patch
  • https://github.com/ClouDev/CloudBot/pull/290.diff

— Reply to this email directly or view it on GitHub https://github.com/ClouDev/CloudBot/pull/290.

literalplus avatar Jun 19 '14 13:06 literalplus

I'm assuming it's some kind of stats tracking on their end

On Fri, Jun 20, 2014 at 1:31 AM, xxyy [email protected] wrote:

What is the benefit of adding this?

-- Above message was sent from my mobile phone. There may and will be all kinds of errors included. For free! On 19 Jun 2014 07:19, "Eric Case" [email protected] wrote:


You can merge this Pull Request by running

git pull https://github.com/case/CloudBot patch-1

Or view, comment on, or merge it at:

https://github.com/ClouDev/CloudBot/pull/290 Commit Summary

  • Add client_id to requests

File Changes

  • M plugins/domainr.py https://github.com/ClouDev/CloudBot/pull/290/files#diff-0 (2)

Patch Links:

  • https://github.com/ClouDev/CloudBot/pull/290.patch
  • https://github.com/ClouDev/CloudBot/pull/290.diff

— Reply to this email directly or view it on GitHub https://github.com/ClouDev/CloudBot/pull/290.

— Reply to this email directly or view it on GitHub https://github.com/ClouDev/CloudBot/pull/290#issuecomment-46560017.

dmptrluke avatar Jun 19 '14 14:06 dmptrluke

Apologies for not providing more context — I'm one of the folks who run Domainr, and later this year we're going to be requiring API identifiers of some sort, e.g. API keys. This is part of our preliminary work, to see which current API clients are sending traffic, how much, etc.

In the meantime, you could add your email address to the form linked on our API page — we'll be in touch when we have more details.

-Eric

case avatar Jun 19 '14 14:06 case

^^ bump

case avatar Dec 05 '14 06:12 case

will check soon

On Fri, Dec 5, 2014 at 7:51 PM, Eric Case [email protected] wrote:

^^ bump

— Reply to this email directly or view it on GitHub https://github.com/ClouDev/CloudBot/pull/290#issuecomment-65753890.

dmptrluke avatar Dec 05 '14 16:12 dmptrluke