clickhouse-java icon indicating copy to clipboard operation
clickhouse-java copied to clipboard

Confusion between compress=1 and enable_http_compression ?

Open RonanMorgan opened this issue 5 years ago • 0 comments

Hello,

Another question,

I tried to activate the HTTP gzip compression but when I looked in the code it seems to me that, even if the name of the setting is in the enum ClickHouseQueryParam.java, his behavior is not implemented.

Also, while I was looking for the implementation, I found this line in the code :

.disableContentCompression() // gzip здесь ни к чему. Используется lz4 при compress=1

Which means, I think, "no need to use gzip here, since lz4 is used with compress=1"

But in the clickhouse documentation it's written :

"If you specified compress=1 in the URL, the server compresses the data it sends you."

So am I right if I say that : => there is currently no implementation of the enable_http_compression => the driver is currently not compressing the data content of the HTTP POST request => this comment is wrong since we could use the HTTP compression for the request and compress=1 for the answers

RonanMorgan avatar Nov 17 '20 14:11 RonanMorgan