click-ui icon indicating copy to clipboard operation
click-ui copied to clipboard

add border prop to Container

Open Kinzeng opened this issue 1 year ago • 2 comments

Kinzeng avatar Sep 16 '24 21:09 Kinzeng

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
click-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 9:49pm

vercel[bot] avatar Sep 16 '24 21:09 vercel[bot]

Hmm I don't know about this, until now we've said that the container is for applying layouts only, an invisible element that controls the positioning of other components, so we haven't added borders, shadows, background colours etc. @vineethasok thoughts?

gjones avatar Sep 16 '24 23:09 gjones

@Kinzeng @gjones I'm also against this Since we have panel I don't think we should add these to containers

vineethasok avatar Nov 25 '24 06:11 vineethasok

Agreed, let's close this one and adjust panel if we feel there is anything missing from it.

gjones avatar Dec 12 '24 05:12 gjones