click-ui icon indicating copy to clipboard operation
click-ui copied to clipboard
verified publisher icon ClickHouse

Adding size and colour to Avatar component

Open gjones opened this issue 1 year ago • 1 comments

Summary

Adding the option of choosing between md and sm for the size of the Avatar. Also Adding different options for colours. Starting with 3, can add more easily later.

https://github.com/user-attachments/assets/bdab443d-8b2f-4509-a815-b3950c8ff540

gjones avatar Aug 19 '24 18:08 gjones

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
click-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 6:29pm

vercel[bot] avatar Aug 19 '24 18:08 vercel[bot]

What if we change the name of the component to something more generalized? CircularContainer, something like that. It seems like the element has different use cases, not avatar only.

rndD avatar Aug 20 '24 13:08 rndD

Also additional use cases: image

For it we need to more colors

rndD avatar Aug 20 '24 13:08 rndD

I think that is extending Click Icon to have a backgroundColour prop.

gjones avatar Aug 20 '24 23:08 gjones

I think that is extending Click Icon to have a backgroundColour prop.

What about a rounded shape? Should it be a custom or added to <Icon /> too?

rndD avatar Aug 22 '24 09:08 rndD

I'll close this as the changes I made are not consistent with what an avatar actually is.

gjones avatar Aug 22 '24 20:08 gjones