AdaptiveTableLayout icon indicating copy to clipboard operation
AdaptiveTableLayout copied to clipboard

Fixes for issues #40, #38, #43, #42, #44, #45, #36 & #47

Open vyguera opened this issue 6 years ago • 3 comments

Fixes for issues #40, #38, #43, #42, #44, #45, #36 & #47:

  • I made some cleaning up to avoid having to add 'tools:replace="android:allowBackup"' to element at AndroidManifest.xml when developers sets their own allowBackup value on their actual application

  • Also I refactored to Android X with Android Studio's refactoring tool, what also allowed me to upload API Level to 29. As a result, save button does not save to External Storage anymore, I had to save them in internal storage.

  • Besides sample didn't work on API Level 16. I've fixed this although images still won't be loaded as of some errors on Glide I cannot solve. Anyway not showing images are better than a crash.

  • Furthermore I fixed a crash when loading an Adapter with no data. This is no rows and/or no columns.

  • I fixed AdaptiveTableLayout.notifyDataSetChanged() too as it didn't refresh with new data.

  • I solved a problem when using any notify* method as top left corner wasn't changing.

  • Last but not least I made ViewHolder interface public to support Kotlin applications

vyguera avatar Dec 30 '19 11:12 vyguera

Hello vyguera,

Thanks for this pull request. Hope it's will be merged as soon as possible. Meanwhile, can I host your fork on maven to use it in our application ? We also can help on further improvement or new enhancement.

Best regards, Louis

GautierLouis avatar Mar 03 '20 15:03 GautierLouis

Hi Louis,

Of course you can. Glad to read your proposal. Let me know about the public url if available as I'd like to switch to a repository in my projects, too.

vyguera avatar Mar 03 '20 15:03 vyguera

Hello vyguera, Sorry for the delay, I've finally pushed the code to Maven. I had to fork your repository. You can see it here https://github.com/daxium/AdaptiveTableLayout And use the lib in your projects by using : implementation "io.github.daxium:adaptivetablelayout:1.3.0"

GautierLouis avatar Apr 01 '20 08:04 GautierLouis