clevertap-react-native icon indicating copy to clipboard operation
clevertap-react-native copied to clipboard

incorrect type definitions

Open LonelyCpp opened this issue 3 years ago • 1 comments

missing types

types for these exported constants are missing in index.d.ts

FCM: CleverTapReact.FCM,
XPS: CleverTapReact.XPS,
BPS: CleverTapReact.BPS,
HPS: CleverTapReact.HPS,

incorrect types

both profileGetCleverTapAttributionIdentifier and profileGetCleverTapID have incorrect callback types.

index.d.ts says they both get a callback with res as an "object", but both get "string" in their callbacks


please add a @deprecated tag in the comments rather than just saying "this is deprecated". IDEs actually warn users when it sees this tag

LonelyCpp avatar Oct 20 '22 12:10 LonelyCpp

@LonelyCpp Thanks for feedback. This will get fixed in next release.

piyush-kukadiya avatar Oct 21 '22 06:10 piyush-kukadiya