components icon indicating copy to clipboard operation
components copied to clipboard

add present gift for dark background

Open eighnjel opened this issue 8 years ago • 5 comments

Overview:

  • Add present icon for dark backgrounds (see below for current and new)

Screenshots/GIFs: image

Testing:

  • [ ] Unit tests
  • Manual tests:
    • [ ] Chrome
    • [ ] Safari
    • [ ] IE10

Roll Out:

  • Before merging:
    • [ ] Updated docs
    • [ ] Bumped version in package.json
      • Breaking change? Run npm version minor
      • Backward compatible change? Run npm version patch
      • Only changing documentation? All good. Skip this step.
  • After merging:
    • [ ] Deployed updated docs (make deploy-docs)

eighnjel avatar Jan 26 '18 20:01 eighnjel

We might want to adjust the colors of the dark background version. The white outline + dark background of the gift is a bit intense.

CarlNelson avatar Jan 26 '18 20:01 CarlNelson

cc @mischelle-m who's working on it

eighnjel avatar Jan 26 '18 20:01 eighnjel

image

changed white outline into @neutral_silver to reduce the intense contrast, thoughts @CarlNelson?

mischelle-m avatar Jan 26 '18 20:01 mischelle-m

Still very visually jarring, let's chat.

CarlNelson avatar Jan 26 '18 21:01 CarlNelson

We're just going to change this, so we can pause on iteration for now.

eighnjel avatar Jan 29 '18 18:01 eighnjel