Add Whitelist

[Banaanae]

This PR adds a whitelist button, which then allows users to prevent sites from being filtered Whitelisting is now pretty much finished, only the issue with subdomains being treated like separate sites remain, just waiting on maintainer's opinions on adding another library. (If current behaviour is also like there could be an option in settings) This PR has only been tested on firefox, if chrome users could test it be greatly appreciated

• [ ] Make whitelist for full domain (currently if www.example.com is whitelisted, example.com isn't. This could be considered intentional, but it would still break cases like www.example.com calling assets.example.com)
• [x] Allow users to unwhitelist whitelisted sites (only possible via full reset atm, would replace Whitelist Site with Remove From Whitelist when viewing a whitelisted page)
• • [x] Update button after user presses it
• • [x] Make button spam resistant
• [x] List whitelisted sites in settings
• [x] Fix styling
• [x] Support for ip addresses? (Might already be working, untested)
• [ ] Whitelist sites on per rule basis (meaning exempt a site from one rule but not another, requested in #93, but might not be added in this PR)

Once done this will close #93 and its many duplicates

[Banaanae]

[Banaanae]

Using a library like tld.js could fix the first issue Alternatively we could parse the psl ourselves, but seems redundant because of above lib

[Banaanae]

[Banaanae]

I'm marking this as ready for review, before merging a few things need to happen

• Chrome testing
• Decide on if tld.js should be used to fix first task

_{Not going to do the last task, a bit above my skill level}

[Banaanae]

@KevinRoebert do you have any plans to merge this? If you'd rather me create this on gitlab I have finally got my account unblocked :) I know you are in the process of rewriting this extension, (with whitelisting being included), but it has been some time since that announcement, (maybe merge this in the mean time, and then replace my stuff with your fix?). This has been one of the most requested features.

[rdslw]

Would be great to have it, as currently clearurls breaks amazon sorting, resulting in user not being able to select any other sorting.

[KevinRoebert]

@Banaanae First of all, thank you for your contribution.

I am currently reviewing the code. It still needs some changes and also has a couple of bugs. I will make the changes directly and then merge.

[KevinRoebert]

https://gitlab.com/ClearURLs/ClearUrls/-/merge_requests/110

[Acleacius]

Thanks for your work, just noticed as I was posting in the other thread about a new issue I found, unrelated to your fix.

I'm gonna quote my post as to not retype it, just thought if your actively working on it you might be interested. :)

New issue at least to me, when using Google Maps it keeps the url locked so Google can't zoom in and auto readjust positioning. It also means many normal functions on Google Maps don't work such as clicking on a POI to get the popup and all the information provided. Such as Hours of Operation, Crowd Size (haha) atm and Addresses.

Personally, I still use this mod BUT it's really good to get a list of places and situations, so we can be aware to disable manually as necessary.

Looking forward to trying your fixes! :D

[junginlee82]

Eagerly awaiting this! (Or please kindly point to where I can download this build!)

[Serubin]

Bumping this - tons of sites are broken, most critical the google drive suite. This really needs more attention

[KMohZaid]

i missed this PR and related issue and made new PR #383

[LaDorade]

any news about that ?

[Neustradamus]

@Banaanae: Can you create a PR on Gitlab too?

• https://gitlab.com/ClearURLs

If it is not merged, I think it is the moment to fork this project.

[Banaanae]

@Neustradamus this was done in https://github.com/ClearURLs/Addon/pull/372#issuecomment-2227361033 I don't think it makes a difference if I made another one