Ciw icon indicating copy to clipboard operation
Ciw copied to clipboard

Update node.py: `!= False`

Open galenseilis opened this issue 2 years ago • 2 comments

I don't think != False is necessary here.

galenseilis avatar Jan 14 '24 01:01 galenseilis

Looks like the version of Sphinx might need to be updated.

galenseilis avatar Jan 14 '24 01:01 galenseilis

Here we are explicitly checking if self.priority_preempt is False or not. Although I believe leaving out the != False works, the other values that self.priority_preempt can take are all strings, not True, and so to be explicit and to avoid any unintended behaviour, I think this should be retained.

geraintpalmer avatar Apr 03 '24 13:04 geraintpalmer