Editing form

[jbelien]

Hi,

I have some remarks about the form to edit an POI (I tried to edit informations about amenity=restaurant) :

• [x] Impossible to enter/edit houser number (also impossible to view the house number)
• [x] Impossible to enter/edit postal code (also impossible to view the postal code)
• [ ] It's only possible to enter the same opening hours for each day but there are a lot of shops/restaurant that have different opening hours if it's the week or the weekend, see #87

Warning : The format of opening hours is wrong ! Should be hh:mm-hh:mm (with a dash) instead of hh:mm:hh:mm !

Also, it send a changeset request every time you tap on the mark to save your changes. I think it should only send a request if there is a change ! (see http://www.openstreetmap.org/node/866333004/history ; I accidentally double tapped on the mark and it sent 2 identical requests but with a "strange" message : Updatin for the 2nd changeset request)

[rskikuli]

@jbelien thank you so much for taking the time to review the app even in the early alpha version of it. We will wait for some more days to get more feedback from you and other testers in order to review and implement the changes. Again thanks for getting involved, we really appreciate it. If you have other comments and have found some more bugs please add them here @ Github.

[rskikuli]

Here are some comments based on your feedback @jbelien:

impossible to enter/edit houser number (also impossible to view the house number);

Valid point. We were based on the needs of Tirana address system when we created this. This will be added on the v1.0 that will be released on F-droid.

Impossible to enter/edit postal code (also impossible to view the postal code)

Another valid point. Same answer with the previous issue.

It's only possible to enter the same opening hours for each day but there are a lot of shops/restaurant that have different opening hours if it's the week or the weekend.

Valid, but we were thinking of adding this at v2.0 release. If you or someone else can help us coding this would really help us (blame limited resources at the moment).

The format of opening hours is wrong ! Should be hh:mm-hh:mm (with a dash) instead of hh:mm:hh:mm !

Can you review this again? This is how it is implemented at the moment and is exactly as you mentioned. Have a look at the code please: https://github.com/CityZenApp/CityZen-Android/blob/master/CityZenApp/app/src/main/java/com/cityzen/cityzen/Utils/MapUtils/OpeningHours/OpeningHoursUtils.java CityZen supports some of the date formats as documented at this link, but not all of them at the moment: http://wiki.openstreetmap.org/wiki/Key:opening_hours. Having said this, it shouldn't be an issue since we have based the hours system based on OSM. What do you think?

[jbelien]

Can you review this again? This is how it is implemented at the moment and is exactly as you mentioned. Have a look at the code please: https://github.com/CityZenApp/CityZen-Android/blob/master/CityZenApp/app/src/main/java/com/cityzen/cityzen/Utils/MapUtils/OpeningHours/OpeningHoursUtils.java CityZen supports some of the date formats as documented at this link, but not all of them at the moment: http://wiki.openstreetmap.org/wiki/Key:opening_hours. Having said this, it shouldn't be an issue since we have based the hours system based on OSM. What do you think?

I'll have a look at the code ... My comment was made following an edit I made using CityZen app (see http://www.openstreetmap.org/changeset/51206307) : opening_hours = Mo-Sa 18:30:22:30

[rskikuli]

@jbelien can you please test this again using the latest version that is launched on F-Droid? You can find it here: http://cityzenapp.co/.

[rskikuli]

@jbelien some feedback regarding your comments below:

Impossible to enter/edit houser number (also impossible to view the house number) This is implemented in version v 1.0 Impossible to enter/edit postal code (also impossible to view the postal code) Also implemented in v 1.0
It's only possible to enter the same opening hours for each day but there are a lot of shops/restaurant that have different opening hours if it's the week or the weekend @sidorelauku can you add a separate issue for this? Planned for ver 1.3. Once done let's close this issue please. Thanks