Citizens2 icon indicating copy to clipboard operation
Citizens2 copied to clipboard

Sheep NPC do not always update for players when changing dye colour and name

Open coolnickname opened this issue 3 years ago • 4 comments

/version output

This server is running Paper version git-Paper-792 (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT)
You are 2 version(s) behind
Previous version: git-Paper-778 (MC: 1.16.5)

/version Citizens output

Citizens version 2.0.30-SNAPSHOT (build 2673)
Website: http://www.citizensnpcs.co
Author: fullwall

Log file

https://paste.denizenscript.com/View/100904

config.yml

https://paste.denizenscript.com/View/100905

saves.yml

last-created-npc-id: 723 npc: {}

Profiler report

No response

Description

When I change the dye colour and name of my sheep NPC it sometimes doesn't update for players that are already in the world. Players that teleport into the world afterwards see the updated colour and name, but players that were there before the update don't.

I use an anonymous NPC registry and the change the colour and name as follows: npcRegistry.getNPC(sheep).setName(text); ((Sheep) sheep).setColor(color) where sheep is an instance of LivingEntity.

Would it be possible to send some packet to the client to update the entity?

coolnickname avatar Sep 03 '22 16:09 coolnickname

https://wiki.citizensnpcs.co/Cracks

BehrRiley avatar Sep 03 '22 16:09 BehrRiley

@BehrRiley the server is normally run behind a proxy so it has to be in offline mode

coolnickname avatar Sep 03 '22 16:09 coolnickname

@BehrRiley the server is normally run behind a proxy so it has to be in offline mode

please refer to the link provided; the note you specified is outlined here: https://wiki.citizensnpcs.co/Cracks#Bungee your backend servers should be offline to allow your proxy to firewall it in an online-mode - you should correct that as players can join your server without authenticating properly, making it a cracked server. we do not support cracked servers

BehrRiley avatar Sep 03 '22 16:09 BehrRiley

@BehrRiley This is not the production server, but a copy I downloaded to my PC to test my plugins on. I just haven't bothered to change the online mode setting because the server is only running when I am testing something and is not exposed to the internet.

Maybe I should have mentioned that from the beginning, but I didn't figure it would be such a big deal. For the record: the accounts I used are both authenticated, and I would be more than happy to recreate the issue in an online mode environment if that would help.

coolnickname avatar Sep 03 '22 16:09 coolnickname

This issue has not been resolved yet. Please reopen.

coolnickname avatar Apr 04 '23 16:04 coolnickname

Need replication logs on an up-to-date online-mode server

mcmonkey4eva avatar Apr 04 '23 17:04 mcmonkey4eva

I still can't reproduce this. Need clear reproduction steps.

fullwall avatar Mar 03 '24 15:03 fullwall