linutil icon indicating copy to clipboard operation
linutil copied to clipboard

Docker Setup

Open Sergiogd112 opened this issue 1 year ago • 10 comments

Pull Request

Title

Docker Setup

Type of Change

  • [x] New feature
  • [ ] Bug fix
  • [ ] Documentation Update
  • [ ] Refactoring
  • [ ] Hotfix
  • [ ] Security patch
  • [ ] UI/UX improvement

Description

Adds an option to install and set up docker. The option was set under the System-Setup tab. The code is based on the official documentation.

Testing

It was tested on:

  • PopOs
  • Ubuntu 24.04
  • Arch
  • Fedora 40 As a non-root user, I was able to start the hello-world container without errors.

It should also support Debian but I could not set up a VM to test it.

Additional Information

After doing my first issue (#225) I decided to try and help out the project. This is my first PR so if there's any advice you can provide, I'd be very grateful for it.

Checklist

  • [X] My code adheres to the coding and style guidelines of the project.
  • [X] I have performed a self-review of my own code.
  • [X] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [X] My changes generate no errors/warnings/merge conflicts.

Sergiogd112 avatar Sep 07 '24 18:09 Sergiogd112

@Sergiogd112 for debian this is easier commands.

for installing docker, curl -fsSL https://get.docker.com -o get-docker.sh sh get-docker.sh for installing docker compose sudo apt-get update sudo apt-get install docker-compose-plugin

and yeah theres no need to run systemctl for this script which is from the official docker page. and to run docker compose, its "docker compose"

guruswarupa avatar Sep 07 '24 18:09 guruswarupa

@Sergiogd112 for debian this is easier commands.

for installing docker, curl -fsSL https://get.docker.com -o get-docker.sh sh get-docker.sh for installing docker compose sudo apt-get update sudo apt-get install docker-compose-plugin

Thank for the review, but I don't understand what are the benefits in using your version. Also, which one should I use?

curl -fsSL https://get.docker.com/ -o get-docker.sh
sh get-docker.sh

Or

curl -fsSL https://get.docker.com/ | sh

Sergiogd112 avatar Sep 07 '24 19:09 Sergiogd112

Thanks. @Sergiogd112

ghost avatar Sep 07 '24 20:09 ghost

Thanks. @Sergiogd112

Glad I could help :)

Sergiogd112 avatar Sep 07 '24 20:09 Sergiogd112

@Sergiogd112 for debian this is easier commands.

for installing docker, curl -fsSL https://get.docker.com -o get-docker.sh sh get-docker.sh for installing docker compose sudo apt-get update sudo apt-get install docker-compose-plugin

Thank for the review, but I don't understand what are the benefits in using your version. Also, which one should I use?

curl -fsSL https://get.docker.com/ -o get-docker.sh
sh get-docker.sh

Or

curl -fsSL https://get.docker.com/ | sh

Just look at the number of lines your writing manually when the script does all that for u. That script seems to support centos, debian , Ubuntu , fedora, rhel.

guruswarupa avatar Sep 08 '24 04:09 guruswarupa

56 commits 27 changed files. 0_0

ghost avatar Sep 11 '24 10:09 ghost

@nnyyxxxx what just happenned to this pr? lol . it has like broken cargo.lock too ig.

guruswarupa avatar Sep 11 '24 10:09 guruswarupa

@nnyyxxxx what just happenned to this pr? lol . it has like broken cargo.lock too ig.

Failed rebase.

ghost avatar Sep 11 '24 10:09 ghost

@nnyyxxxx what just happenned to this pr? lol . it has like broken cargo.lock too ig.

Failed rebase.

Basically, I traed to fixed the cargo lock problem and it got a bit out of hand 😅

Sergiogd112 avatar Sep 11 '24 22:09 Sergiogd112

@nnyyxxxx what just happenned to this pr? lol . it has like broken cargo.lock too ig.

Failed rebase.

Basically, I traed to fixed the cargo lock problem and it got a bit out of hand 😅

You should either rebase this to fix the commit log or close this. I'm not sure Chris will accept this otherwise, him having to go through all these PRs + having to then fix this ones log he'll probably just close this.

ghost avatar Sep 11 '24 22:09 ghost