linutil icon indicating copy to clipboard operation
linutil copied to clipboard

Fixes to keymap configuration in Arch Server Script

Open avaera8775 opened this issue 1 year ago • 1 comments

Pull Request

Title

Smaller bugfix to keymap selection

Type of Change

  • [ ] New feature
  • [X] Bug fix
  • [ ] Documentation Update
  • [ ] Refactoring
  • [X] Hotfix
  • [ ] Security patch
  • [ ] UI/UX improvement

Description

I've noticed that occationally vconsole and locale.conf isn't updated correctly when selecting se keymap and likely other keymaps aside of us. This PR will force an update to each file before finilizing the installation script.

Also added a "Finished" message at the end, after the "Cleaning" block.

Testing

I've run several tests and script works as expected. Installation time isn't impacted.

Additional Information

Nothing critical, but it saves the user some headache from having to manually editting the .conf files post-installation.

Checklist

  • [X] My code adheres to the coding and style guidelines of the project.
  • [X] I have performed a self-review of my own code.
  • [X] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] My changes generate no errors/warnings/merge conflicts.

avaera8775 avatar Sep 05 '24 22:09 avaera8775

Updated the se keymap to sv-latin1. It was giving danish (our enemy!) keystrokes for certain letters. This resolves that so swedish users can use our dumb symbols.

I realise that 1 section of this PR could be seperated but given it so small, I thought it might be acceptable.

avaera8775 avatar Sep 06 '24 15:09 avaera8775